Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New rule S2970: Assertions should be complete #6757

Merged
merged 35 commits into from Feb 27, 2023
Merged

New rule S2970: Assertions should be complete #6757

merged 35 commits into from Feb 27, 2023

Commits on Feb 20, 2023

  1. Add KnownAssembly MSTest and MSTestAssert

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    3cbce45 View commit details
    Browse the repository at this point in the history

  2. Add remark for compatibility

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    cd724cb View commit details
    Browse the repository at this point in the history

  3. Scaffold rule

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    cfa25e7 View commit details
    Browse the repository at this point in the history

  4. WIP: Register MSTest

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    4093321 View commit details
    Browse the repository at this point in the history

  5. Remove Assert_That from KnownAssemblies as it does not bring much to … 

    …the table
    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    5897871 View commit details
    Browse the repository at this point in the history

  6. Add support for NFluent, NSubsutiture and FluentAssertion

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    16a04a3 View commit details
    Browse the repository at this point in the history

  7. wip: add checks

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    3067aea View commit details
    Browse the repository at this point in the history

  8. WIP: Add implementation and test for FluentAssertion

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    7450e81 View commit details
    Browse the repository at this point in the history

  9. Add support for custom assertions

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    a6c9549 View commit details
    Browse the repository at this point in the history

  10. Move nullable tests in own test file and fix Netframework dependencies

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    4991d86 View commit details
    Browse the repository at this point in the history

  11. Add type argument test

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    e6a630c View commit details
    Browse the repository at this point in the history

  12. Demonstrate better overload resolution inC#8 vs C#7

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    286b13b View commit details
    Browse the repository at this point in the history

  13. Fix wrong annotated compiler error

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    d7be4d9 View commit details
    Browse the repository at this point in the history

  14. Add KnownTypes after rebase

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    c4340a8 View commit details
    Browse the repository at this point in the history

  15. Add comment

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    8531f37 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. NFluent: Add tests

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    0f95790 View commit details
    Browse the repository at this point in the history

  2. Add tests for NFluent

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    d275172 View commit details
    Browse the repository at this point in the history

  3. Add test for other compliant Check class

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    53b00f6 View commit details
    Browse the repository at this point in the history

  4. formatting

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    a5bd203 View commit details
    Browse the repository at this point in the history

  5. formatting

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    1baf1ff View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. Add tests for NSubstitute

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    c399c2f View commit details
    Browse the repository at this point in the history

  2. Refactorings

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    76fb2ad View commit details
    Browse the repository at this point in the history

  3. Add tests for lambdas and locla functions

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    69d142c View commit details
    Browse the repository at this point in the history

  4. Add more fine grained tests for valid continuations and fix some bugs.

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    d960499 View commit details
    Browse the repository at this point in the history

  5. Fix code smells

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    d67b3ab View commit details
    Browse the repository at this point in the history

  6. Refactor HasContinuation

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    3b99c79 View commit details
    Browse the repository at this point in the history

  7. Move IsVoid in the switch arm expression

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    5028c04 View commit details
    Browse the repository at this point in the history

  8. Add test for missing close paran

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    5f1eeae View commit details
    Browse the repository at this point in the history

  9. Add tests for IsName overload

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    490e1fe View commit details
    Browse the repository at this point in the history

  10. Add tests for all framework usages in one file

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    7fcea44 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. Fix test method name

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    dde49fb View commit details
    Browse the repository at this point in the history

  2. Remove CSharp using from test file

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    d087c8c View commit details
    Browse the repository at this point in the history

  3. Formatting

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    923500c View commit details
    Browse the repository at this point in the history

  4. Update analyzers/tests/SonarAnalyzer.UnitTest/TestCases/AssertionsSho… 

    …uldBeComplete.NFluent.cs

Co-authored-by: Tim Pohlmann <tim.pohlmann@sonarsource.com>
    @martin-strecker-sonarsource @Tim-Pohlmann
    martin-strecker-sonarsource and Tim-Pohlmann committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    264f688 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. Update RSpec

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    b252275 View commit details
    Browse the repository at this point in the history