Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New rule S2970: Assertions should be complete #6757

Merged
merged 35 commits into from Feb 27, 2023
Merged

New rule S2970: Assertions should be complete #6757

merged 35 commits into from Feb 27, 2023

Conversation

martin-strecker-sonarsource
Copy link
Contributor

Fixes #6662

@martin-strecker-sonarsource martin-strecker-sonarsource mentioned this pull request Feb 20, 2023
Merged
@martin-strecker-sonarsource martin-strecker-sonarsource marked this pull request as ready for review February 22, 2023 15:52
Tim-Pohlmann
Tim-Pohlmann requested changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@Tim-Pohlmann Tim-Pohlmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides some nitpicking.
Was it considered to add support for FakeItEasy?
It has some assertion calls that could be checked in a very similar manner:
A.CallTo(() => shop.BuyCandy(lollipop)).MustHaveHappened();

analyzers/src/SonarAnalyzer.CSharp/Helpers/CSharpSyntaxHelper.cs Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/AssertionsShouldBeComplete.cs Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/Rules/AssertionsShouldBeCompleteTest.cs Show resolved Hide resolved
...ests/SonarAnalyzer.UnitTest/TestCases/AssertionsShouldBeComplete.FluentAssertions.CSharp7.cs Show resolved Hide resolved
...ests/SonarAnalyzer.UnitTest/TestCases/AssertionsShouldBeComplete.FluentAssertions.CSharp7.cs Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/AssertionsShouldBeComplete.NFluent.cs Outdated Show resolved Hide resolved
@martin-strecker-sonarsource
Copy link
Contributor Author

Was it considered to add support for FakeItEasy?

No. There is also moq Verify and probably others. I can not tell why NSubstitute was included, but Moq and FakeItEasy were not. We also looked into NUnit, xUnit, and Shoudly.

@martin-strecker-sonarsource @Tim-Pohlmann
Update analyzers/tests/SonarAnalyzer.UnitTest/TestCases/AssertionsSho…
264f688 
…uldBeComplete.NFluent.cs

Co-authored-by: Tim Pohlmann <tim.pohlmann@sonarsource.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Feb 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.2% 95.2% Coverage
0.0% 0.0% Duplication

@martin-strecker-sonarsource martin-strecker-sonarsource deleted the Martin/S2970_CompleteAssertion branch February 27, 2023 15:47
@martin-strecker-sonarsource
Copy link
Contributor Author

Peach validation found one TP:
https://peach.sonarsource.com/project/issues?issues=AYabOF5d3yCAlhNoZFCD&open=AYabOF5d3yCAlhNoZFCD&id=csharp-language-server-protocol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tim-Pohlmann Tim-Pohlmann Tim-Pohlmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New rule S2970: Assertions should be complete
2 participants
@martin-strecker-sonarsource @Tim-Pohlmann