Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S2699 FP: Support overridden methods annotated with AssertionMethodAttribute #6652

Merged
merged 24 commits into from Mar 14, 2023
Merged

Fix S2699 FP: Support overridden methods annotated with AssertionMethodAttribute #6652

merged 24 commits into from Mar 14, 2023

Commits on Jan 17, 2023

  1. WIP: Add support for InheritedAttributes for methods

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    992760e View commit details
    Browse the repository at this point in the history

  2. Remove unsed using

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    5edbd1f View commit details
    Browse the repository at this point in the history

  3. Add test for TypeSymbol and clean up

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    c55ae73 View commit details
    Browse the repository at this point in the history

  4. Fix FP

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    f00585f View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. Move AttributeUsageInherited and add more tests.

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    12f4797 View commit details
    Browse the repository at this point in the history

  2. Improve doc comment.

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    adf4e69 View commit details
    Browse the repository at this point in the history

  3. More code comments for clarity

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    7bd37c9 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Pavel Mikula <57188685+pavel-mikula-sonarsource@users.noreply.github.com>
    @martin-strecker-sonarsource @pavel-mikula-sonarsource
    martin-strecker-sonarsource and pavel-mikula-sonarsource committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    e6819a8 View commit details
    Browse the repository at this point in the history

  5. Fix after merge

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    f85288b View commit details
    Browse the repository at this point in the history

  6. Make compilation private field

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    31a72be View commit details
    Browse the repository at this point in the history

  7. Add comment

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    339746a View commit details
    Browse the repository at this point in the history

  8. Fix comment

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    a594007 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. Add doc comment

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    2ebc6ac View commit details
    Browse the repository at this point in the history

  2. Remove doc comment.

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    1fdc7ba View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. Add test for duplicate AttributeUsage attribute

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    8810dff View commit details
    Browse the repository at this point in the history

  2. Add inherit doc

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    afff954 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2023

  1. Remove GetDiagnostics from SnippetCompiler and make Compilation publi… 

    …c instead
    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    835c6f0 View commit details
    Browse the repository at this point in the history

  2. Code review

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    e2224f8 View commit details
    Browse the repository at this point in the history

  3. Better align test cases

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    3db33a0 View commit details
    Browse the repository at this point in the history

  4. Simplify string

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    23501da View commit details
    Browse the repository at this point in the history

  5. inline assembly

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    6e39239 View commit details
    Browse the repository at this point in the history

  6. Simplify test class

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    825fedf View commit details
    Browse the repository at this point in the history

  7. Remove "My" prefix from attributes

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    297a031 View commit details
    Browse the repository at this point in the history

  8. Rearrange test cases

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    42e1eb4 View commit details
    Browse the repository at this point in the history