Fix S2699 FP: Support overridden methods annotated with AssertionMethodAttribute #6652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-strecker-sonarsource
force-pushed
the
Martin/S2699_SupportInheritedAttributes
branch
from
fadd232
to
f00585f
Compare
| [DataTestMethod] | ||
| [DataRow(true, true)] | ||
| [DataRow(false, true)] // The "Inherited" flag is not inherited for the AttributeUsage attribute itself. See also the SymbolHelperTest.GetAttributesWithInherited... tests, | ||
| // where the reflection behavior of MemberInfo.GetCustomAttributes is also tested. |
There was a problem hiding this comment.
This is a bit surprsing because AttributeUsageAttribute has Inherited = true but it seems it is not respected by GetCustomAttributes.
|
|
||
| [DataTestMethod] | ||
| [DataRow("BaseClass`1", "MyInheritedAttribute", "MyDerivedInheritedAttribute", "MyNotInheritedAttribute", "MyDerivedNotInheritedAttribute", "MyUnannotatedAttribute")] | ||
| [DataRow("DerivedOpenGeneric`1", "MyInheritedAttribute", "MyDerivedInheritedAttribute", "MyDerivedNotInheritedAttribute", "MyUnannotatedAttribute")] |
There was a problem hiding this comment.
Here MyNotInherited is not returned by GetCustomAttributes as expected, but MyDerivedNotInherited is returned. GetCustomAttributes is the source of truth and so we need to follow that behavior here.
pavel-mikula-sonarsource
requested changes
Jan 23, 2023
analyzers/tests/SonarAnalyzer.UnitTest/TestFramework/SnippetCompiler.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestFramework/SnippetCompiler.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestFramework/SnippetCompiler.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestFramework/SnippetCompiler.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Pavel Mikula <57188685+pavel-mikula-sonarsource@users.noreply.github.com>
pavel-mikula-sonarsource
requested changes
Jan 25, 2023
analyzers/src/SonarAnalyzer.Common/Extensions/AttributeDataExtensions.cs
Outdated
Show resolved
Hide resolved
|
@martin-strecker-sonarsource what is needed to close this one? |
|
@andrei-epure-sonarsource there were only some doc comment changes left which I just fixed. Can you approve or should I ask some else from the team? |
martin-strecker-sonarsource
requested a review
from pavel-mikula-sonarsource
|
Can you please rebase, just to avoid surprises. As this has been around for a while and it bit me recently |
pavel-mikula-sonarsource
requested changes
Mar 1, 2023
analyzers/tests/SonarAnalyzer.UnitTest/TestFramework/SnippetCompiler.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/Extensions/AttributeDataExtensionsTest.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/Extensions/AttributeDataExtensionsTest.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/Extensions/AttributeDataExtensionsTest.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/Extensions/AttributeDataExtensionsTest.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/Helpers/SymbolHelperTest.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/Helpers/SymbolHelperTest.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/Helpers/SymbolHelperTest.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/Helpers/SymbolHelperTest.cs
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
pavel-mikula-sonarsource
approved these changes
Mar 3, 2023
|
ah, master is locked, we don't need drafts anymore |
martin-strecker-sonarsource
deleted the
Martin/S2699_SupportInheritedAttributes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6525