New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S3415: Add FN/FP repro for #6630 #6631
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristian-ambrosini-sonarsource
requested a review
from martin-strecker-sonarsource
January 13, 2023 13:31
github-actions
bot
assigned martin-strecker-sonarsource and unassigned cristian-ambrosini-sonarsource
Jan 13, 2023
martin-strecker-sonarsource
requested changes
Jan 13, 2023
...rs/tests/SonarAnalyzer.UnitTest/TestCases/AssertionArgsShouldBePassedInCorrectOrder.Xunit.cs
Show resolved
Hide resolved
github-actions
bot
assigned cristian-ambrosini-sonarsource and unassigned martin-strecker-sonarsource
Jan 13, 2023
cristian-ambrosini-sonarsource
force-pushed
the
cristian/Repro-6630
branch
from
January 16, 2023 12:18
61b23b8
to
3e68e18
Compare
cristian-ambrosini-sonarsource
requested a review
from martin-strecker-sonarsource
January 16, 2023 12:19
github-actions
bot
assigned martin-strecker-sonarsource and unassigned cristian-ambrosini-sonarsource
Jan 16, 2023
martin-strecker-sonarsource
requested changes
Jan 16, 2023
...s/tests/SonarAnalyzer.UnitTest/TestCases/AssertionArgsShouldBePassedInCorrectOrder.MsTest.cs
Show resolved
Hide resolved
github-actions
bot
assigned cristian-ambrosini-sonarsource and unassigned martin-strecker-sonarsource
Jan 16, 2023
cristian-ambrosini-sonarsource
requested a review
from martin-strecker-sonarsource
January 17, 2023 08:40
github-actions
bot
assigned martin-strecker-sonarsource and unassigned cristian-ambrosini-sonarsource
Jan 17, 2023
cristian-ambrosini-sonarsource
force-pushed
the
cristian/Repro-6630
branch
from
January 17, 2023 13:33
ecec117
to
6b1ff54
Compare
cristian-ambrosini-sonarsource
force-pushed
the
cristian/Repro-6630
branch
from
January 23, 2023 08:16
6b1ff54
to
a50cd40
Compare
Kudos, SonarCloud Quality Gate passed! |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
martin-strecker-sonarsource
approved these changes
Jan 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-actions
bot
assigned cristian-ambrosini-sonarsource and unassigned martin-strecker-sonarsource
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for #6630.