S3415: Add FN/FP repro for #6630

SonarSource · Jan 16, 2023 · 3e68e18 · 3e68e18
1 parent 2cd2cc8
commit 3e68e18
Show file tree

Hide file tree

Showing 3 changed files with 53 additions and 0 deletions.
diff --git a/...ests/SonarAnalyzer.UnitTest/TestCases/AssertionArgsShouldBePassedInCorrectOrder.MsTest.cs b/...ests/SonarAnalyzer.UnitTest/TestCases/AssertionArgsShouldBePassedInCorrectOrder.MsTest.cs
@@ -32,3 +32,21 @@ public void Foo()
         }
     }
 }
+
+// https://github.com/SonarSource/sonar-dotnet/issues/6630
+namespace Repro_6630
+{
+    [TestClass]
+    class Program
+    {
+        [TestMethod]
+        public void Foo()
+        {
+            var str = "";
+            Assert.AreEqual(actual: "", expected: str); // Compliant FN
+            Assert.AreEqual(expected: "", actual: str); // Compliant
+            Assert.AreEqual(actual: str, expected: ""); // Noncompliant FP
+            Assert.AreEqual(expected: str, actual: ""); // Noncompliant
+        }
+    }
+}
diff --git a/...tests/SonarAnalyzer.UnitTest/TestCases/AssertionArgsShouldBePassedInCorrectOrder.NUnit.cs b/...tests/SonarAnalyzer.UnitTest/TestCases/AssertionArgsShouldBePassedInCorrectOrder.NUnit.cs
@@ -32,3 +32,21 @@ public void Foo()
         }
     }
 }
+
+// https://github.com/SonarSource/sonar-dotnet/issues/6630
+namespace Repro_6630
+{
+    [TestFixture]
+    class Program
+    {
+        [Test]
+        public void Foo()
+        {
+            var str = "";
+            Assert.AreEqual(actual: "", expected: str); // Compliant FN
+            Assert.AreEqual(expected: "", actual: str); // Compliant
+            Assert.AreEqual(actual: str, expected: ""); // Noncompliant FP
+            Assert.AreEqual(expected: str, actual: ""); // Noncompliant
+        }
+    }
+}
diff --git a/...tests/SonarAnalyzer.UnitTest/TestCases/AssertionArgsShouldBePassedInCorrectOrder.Xunit.cs b/...tests/SonarAnalyzer.UnitTest/TestCases/AssertionArgsShouldBePassedInCorrectOrder.Xunit.cs
@@ -27,3 +27,20 @@ public void Foo()
         }
     }
 }
+
+// https://github.com/SonarSource/sonar-dotnet/issues/6630
+namespace Repro_6630
+{
+    class Program
+    {
+        [Fact]
+        public void Foo()
+        {
+            var str = "";
+            Assert.Equal(actual: "", expected: str); // Compliant FN
+            Assert.Equal(expected: "", actual: str); // Compliant
+            Assert.Equal(actual: str, expected: ""); // Noncompliant FP
+            Assert.Equal(expected: str, actual: ""); // Noncompliant
+        }
+    }
+}