Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Microsoft.Data.SqlClient in S2857. #6351

Merged
merged 2 commits into from Feb 23, 2023
Merged

Support Microsoft.Data.SqlClient in S2857. #6351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63e579b
Support `Microsoft.Data.SqlClient` in S2857.
teo-tsirpanis Nov 10, 2022
fc34664
Update tests.
teo-tsirpanis Jan 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions analyzers/src/SonarAnalyzer.CSharp/Rules/SqlKeywordsDelimitedBySpace.cs
View file
Open in desktop
Expand Up @@ -53,6 +53,7 @@ public sealed class SqlKeywordsDelimitedBySpace : SonarDiagnosticAnalyzer
CSharpSyntaxHelper.BuildQualifiedNameSyntax("System", "Data", "Entity"),
CSharpSyntaxHelper.BuildQualifiedNameSyntax("System", "Data", "Odbc"),
CSharpSyntaxHelper.BuildQualifiedNameSyntax("System", "Data", "OracleClient"),
CSharpSyntaxHelper.BuildQualifiedNameSyntax("Microsoft", "Data", "SqlClient"),
teo-tsirpanis marked this conversation as resolved.
Show resolved Hide resolved
CSharpSyntaxHelper.BuildQualifiedNameSyntax("Microsoft", "Data", "Sqlite"),
SyntaxFactory.IdentifierName("Dapper"),
SyntaxFactory.IdentifierName("NHibernate"),
Expand Down
1 change: 1 addition & 0 deletions analyzers/tests/SonarAnalyzer.UnitTest/MetadataReferences/NuGetMetadataReference.cs
View file
Open in desktop
Expand Up @@ -77,6 +77,7 @@ internal static class NuGetMetadataReference
public static References MicrosoftAzureWebJobsExtensionsDurableTask(string packageVersion = Constants.NuGetLatestVersion) => Create("Microsoft.Azure.WebJobs.Extensions.DurableTask", packageVersion);
public static References MicrosoftAzureWebJobsExtensionsHttp(string packageVersion = Constants.NuGetLatestVersion) => Create("Microsoft.Azure.WebJobs.Extensions.Http", packageVersion);
public static References MicrosoftBuildNoTargets(string packageVersion = "3.1.0") => Create("Microsoft.Build.NoTargets", packageVersion);
public static References MicrosoftDataSqlClient(string packageVersion = "5.1.0") => Create("Microsoft.Data.SqlClient", packageVersion);
public static References MicrosoftDataSqliteCore(string packageVersion = "2.0.0") => Create("Microsoft.Data.Sqlite.Core", packageVersion);
public static References MicrosoftEntityFrameworkCore(string packageVersion) => Create("Microsoft.EntityFrameworkCore", packageVersion);
public static References MicrosoftEntityFrameworkCoreSqliteCore(string packageVersion) => Create("Microsoft.EntityFrameworkCore.Sqlite.Core", packageVersion);
Expand Down
2 changes: 2 additions & 0 deletions analyzers/tests/SonarAnalyzer.UnitTest/Rules/SqlKeywordsDelimitedBySpaceTest.cs
View file
Open in desktop
Expand Up @@ -82,6 +82,7 @@ public class SqlKeywordsDelimitedBySpaceTest
[DataRow("System.Data.Entity")]
[DataRow("System.Data.Odbc")]
[DataRow("Dapper")]
[DataRow("Microsoft.Data.SqlClient")]
[DataRow("Microsoft.Data.Sqlite")]
[DataRow("NHibernate")]
[DataRow("PetaPoco")]
Expand All @@ -91,6 +92,7 @@ public class SqlKeywordsDelimitedBySpaceTest
.AddReferences(MetadataReferenceFacade.SystemData)
.AddReferences(NuGetMetadataReference.Dapper())
.AddReferences(NuGetMetadataReference.EntityFramework())
.AddReferences(NuGetMetadataReference.MicrosoftDataSqlClient())
.AddReferences(NuGetMetadataReference.MicrosoftDataSqliteCore())
.AddReferences(NuGetMetadataReference.MicrosoftSqlServerCompact())
.AddReferences(NuGetMetadataReference.NHibernate())
Expand Down