Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Microsoft.Data.SqlClient in S2857. #6351

Merged
merged 2 commits into from Feb 23, 2023
Merged

Support Microsoft.Data.SqlClient in S2857. #6351

merged 2 commits into from Feb 23, 2023

Conversation

teo-tsirpanis
Copy link
Contributor

@teo-tsirpanis teo-tsirpanis commented Nov 10, 2022 •
edited by martin-strecker-sonarsource

Closes #6580

@martin-strecker-sonarsource
Copy link
Contributor

Related #6205 Created a separate issue for the rule.

@martin-strecker-sonarsource martin-strecker-sonarsource added this to In progress in Best Kanban via automation Dec 19, 2022
@martin-strecker-sonarsource martin-strecker-sonarsource added Type: False Negative Rule is NOT triggered when it should be. Area: C# C# rules related issues. labels Dec 19, 2022
@martin-strecker-sonarsource martin-strecker-sonarsource removed Type: False Negative Rule is NOT triggered when it should be. Area: C# C# rules related issues. labels Dec 21, 2022
Best Kanban automation moved this from In progress to Review in progress Dec 21, 2022
@martin-strecker-sonarsource
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sonarcloud
Copy link

sonarcloud bot commented Dec 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Dec 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@martin-strecker-sonarsource martin-strecker-sonarsource removed this from Review in progress in Best Kanban Dec 22, 2022
@martin-strecker-sonarsource
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

martin-strecker-sonarsource
martin-strecker-sonarsource approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @teo-tsirpanis

@martin-strecker-sonarsource martin-strecker-sonarsource merged commit 53f1a8d into SonarSource:master Feb 23, 2023
@teo-tsirpanis teo-tsirpanis deleted the patch-1 branch February 23, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-strecker-sonarsource martin-strecker-sonarsource martin-strecker-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FN S2857: Add support for Microsoft SqlClient Data Provider for SQL Server
2 participants
@teo-tsirpanis @martin-strecker-sonarsource