Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable razor UTs in-memory compilation #9190

Merged
merged 20 commits into from Apr 26, 2024
Merged

Enable razor UTs in-memory compilation #9190

merged 20 commits into from Apr 26, 2024

Conversation

CristianAmbrosini
Copy link
Contributor

Fixes #9010

@CristianAmbrosini CristianAmbrosini marked this pull request as draft April 23, 2024 14:25
@CristianAmbrosini CristianAmbrosini changed the title Cleanup and removal of the old implementation Enable razor UTs in-memory compilation Apr 23, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Tim-Pohlmann Tim-Pohlmann marked this pull request as ready for review April 25, 2024 11:12
Tim-Pohlmann
Tim-Pohlmann requested changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@Tim-Pohlmann Tim-Pohlmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main code changes look good. I have some comments about the tests.

analyzers/tests/SonarAnalyzer.Test/AnalysisContext/SonarAnalysisContextTest.Register.cs Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.Test/AnalysisContext/SonarAnalysisContextTest.Register.cs Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.Test/Rules/CollectionPropertiesShouldBeReadOnlyTest.cs Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.Test/Rules/AvoidLambdaExpressionInLoopsInBlazorTest.cs Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.Test/Rules/AvoidLambdaExpressionInLoopsInBlazorTest.cs Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.TestFramework.Test/Verification/VerifierTest.cs Outdated Show resolved Hide resolved
....TestFramework/Dependencies/Microsoft.CodeAnalysis.Razor.Compiler.SourceGenerators.deps.json Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.TestFramework/Dependencies/RazorSourceGenerator.razorencconfig Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.TestFramework/Verification/Verifier.cs Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.TestFramework/Verification/Verifier.cs Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 26, 2024

Quality Gate Passed Quality Gate passed for 'SonarAnalyzer for .NET'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 26, 2024

Quality Gate Passed Quality Gate passed for '.NET Analyzers parent'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Tim-Pohlmann
Tim-Pohlmann approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@Tim-Pohlmann Tim-Pohlmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tim-Pohlmann Tim-Pohlmann merged commit 97af801 into master Apr 26, 2024
31 checks passed
@Tim-Pohlmann Tim-Pohlmann deleted the sma/ut-razor-cleaning branch April 26, 2024 13:03
Tim-Pohlmann added a commit that referenced this pull request Apr 26, 2024
@Tim-Pohlmann
Revert "Enable razor UTs in-memory compilation (#9190)"
6164bbe 
This reverts commit 97af801.
pavel-mikula-sonarsource pushed a commit that referenced this pull request Apr 26, 2024
@Tim-Pohlmann
Revert "Enable razor UTs in-memory compilation (#9190)" (#9214)
735b0a1
Tim-Pohlmann pushed a commit that referenced this pull request Apr 30, 2024
@CristianAmbrosini @sebastien-marichal @Tim-Pohlmann
Enable razor UTs in-memory compilation (#9190)
3ce43a1 
Co-authored-by: Sebastien Marichal <sebastien.marichal@sonarsource.com>
@Tim-Pohlmann Tim-Pohlmann mentioned this pull request Apr 30, 2024
Merged
Tim-Pohlmann pushed a commit that referenced this pull request Apr 30, 2024
@CristianAmbrosini @sebastien-marichal @Tim-Pohlmann
Enable razor UTs in-memory compilation (#9190)
b832695 
Co-authored-by: Sebastien Marichal <sebastien.marichal@sonarsource.com>
Tim-Pohlmann pushed a commit that referenced this pull request Apr 30, 2024
@CristianAmbrosini @Tim-Pohlmann
Enable razor UTs in-memory compilation (#9190)
800e07a 
Co-authored-by: Sebastien Marichal <sebastien.marichal@sonarsource.com>

# Conflicts:
#	analyzers/tests/SonarAnalyzer.Test/Rules/Utilities/SymbolReferenceAnalyzerTest.cs
#	analyzers/tests/SonarAnalyzer.Test/TestCases/Utilities/SymbolReferenceAnalyzer/Razor.razor
Tim-Pohlmann pushed a commit that referenced this pull request May 2, 2024
@CristianAmbrosini @Tim-Pohlmann
Enable razor UTs in-memory compilation (#9190)
ea63837 
Co-authored-by: Sebastien Marichal <sebastien.marichal@sonarsource.com>

# Conflicts:
#	analyzers/tests/SonarAnalyzer.Test/Rules/Utilities/SymbolReferenceAnalyzerTest.cs
#	analyzers/tests/SonarAnalyzer.Test/TestCases/Utilities/SymbolReferenceAnalyzer/Razor.razor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastien-marichal sebastien-marichal sebastien-marichal left review comments

@Tim-Pohlmann Tim-Pohlmann Tim-Pohlmann approved these changes

Assignees

@Tim-Pohlmann Tim-Pohlmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable razor UTs in-memory compilation
3 participants
@CristianAmbrosini @Tim-Pohlmann @sebastien-marichal