Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S1144 FP/FN: Do not raise on serializable members #8532

Closed
Tim-Pohlmann opened this issue Jan 15, 2024 · 0 comments · Fixed by #8936
Closed

Fix S1144 FP/FN: Do not raise on serializable members #8532

Tim-Pohlmann opened this issue Jan 15, 2024 · 0 comments · Fixed by #8936
Assignees
Labels
Area: C# C# rules related issues. Area: VB.NET VB.NET rules related issues. Sprint: Hardening Fix FPs/FNs/improvements Type: False Positive Rule IS triggered when it shouldn't be.
Projects
Milestone

Comments

@Tim-Pohlmann
Copy link
Contributor

Tim-Pohlmann commented Jan 15, 2024

S1144 should not be raised for serializable members. This is useful if you cannot change the deserialization process but only need access to a subset of the members. Also, the exception needs to be added to RSPEC. Originally reported in #8504

        [Serializable]
        public class ConfigOptionDto
        {
            private string type;  // FP
            private string key { get; set; }  // FP
            [NonSerialized]
            private string value;  // FN
        }
@Tim-Pohlmann Tim-Pohlmann added Type: False Positive Rule IS triggered when it shouldn't be. Area: VB.NET VB.NET rules related issues. Area: C# C# rules related issues. labels Jan 15, 2024
@Tim-Pohlmann Tim-Pohlmann changed the title Fix S1144 FP/FN: Issue title Fix S1144 FP: Do not raise on serializable members Jan 15, 2024
@Tim-Pohlmann Tim-Pohlmann changed the title Fix S1144 FP: Do not raise on serializable members Fix S1144 FP/FN: Do not raise on serializable members Jan 15, 2024
Tim-Pohlmann added a commit that referenced this issue Jan 15, 2024
Tim-Pohlmann added a commit that referenced this issue Jan 15, 2024
Tim-Pohlmann added a commit that referenced this issue Jan 15, 2024
Tim-Pohlmann added a commit that referenced this issue Jan 17, 2024
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource added this to the 9.23 milestone Mar 18, 2024
@github-actions github-actions bot added this to To do in Best Kanban Mar 18, 2024
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource moved this from To do to In progress in Best Kanban Mar 18, 2024
@costin-zaharia-sonarsource costin-zaharia-sonarsource added the Sprint: Hardening Fix FPs/FNs/improvements label Mar 18, 2024
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Mar 22, 2024
@github-actions github-actions bot moved this from Review in progress to In progress in Best Kanban Mar 22, 2024
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Mar 22, 2024
@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban Mar 22, 2024
@mary-georgiou-sonarsource mary-georgiou-sonarsource removed this from the 9.23 milestone Mar 25, 2024
@mary-georgiou-sonarsource mary-georgiou-sonarsource added this to the 9.24 milestone Mar 25, 2024
Best Kanban automation moved this from Review approved to Validate Peach Mar 28, 2024
@mary-georgiou-sonarsource mary-georgiou-sonarsource moved this from Validate Peach to Done in Best Kanban Apr 2, 2024
@mary-georgiou-sonarsource mary-georgiou-sonarsource modified the milestones: 9.24, 9.23.1 Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: C# C# rules related issues. Area: VB.NET VB.NET rules related issues. Sprint: Hardening Fix FPs/FNs/improvements Type: False Positive Rule IS triggered when it shouldn't be.
Projects
Best Kanban
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants