S1144: Add FP/FN Repro for #8532 (#8534)

SonarSource · Jan 17, 2024 · 1a169a8 · 1a169a8
1 parent 6d42fec
commit 1a169a8
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 0 deletions.
diff --git a/analyzers/tests/SonarAnalyzer.Test/TestCases/UnusedPrivateMember.Fixed.Batch.cs b/analyzers/tests/SonarAnalyzer.Test/TestCases/UnusedPrivateMember.Fixed.Batch.cs
@@ -350,3 +350,11 @@ class Repro_8342
     [Private3] protected void AProtectedMethod() { }
     [Private4] private void APrivateMethodCalledByAPublicMethod() { }
 }
+
+// https://github.com/SonarSource/sonar-dotnet/issues/8532
+[Serializable]
+public class Repro_8532
+{
+    [NonSerialized]
+    private string value;               // FN
+}
diff --git a/analyzers/tests/SonarAnalyzer.Test/TestCases/UnusedPrivateMember.Fixed.cs b/analyzers/tests/SonarAnalyzer.Test/TestCases/UnusedPrivateMember.Fixed.cs
@@ -334,3 +334,11 @@ class Repro_8342
     [Private3] protected void AProtectedMethod() { }
     [Private4] private void APrivateMethodCalledByAPublicMethod() { }
 }
+
+// https://github.com/SonarSource/sonar-dotnet/issues/8532
+[Serializable]
+public class Repro_8532
+{
+    [NonSerialized]
+    private string value;               // FN
+}
diff --git a/analyzers/tests/SonarAnalyzer.Test/TestCases/UnusedPrivateMember.cs b/analyzers/tests/SonarAnalyzer.Test/TestCases/UnusedPrivateMember.cs
@@ -434,3 +434,13 @@ private class Private2Attribute : Attribute { } // Noncompliant: FP: attribute u
     private class Private3Attribute : Attribute { } // Noncompliant: FP: attribute used on a protected method
     private class Private4Attribute : Attribute { } // Noncompliant: FP: attribute used on a private method used by a public method
 }
+
+// https://github.com/SonarSource/sonar-dotnet/issues/8532
+[Serializable]
+public class Repro_8532
+{
+    private string type;                // Noncompliant FP
+    private string key { get; set; }    // Noncompliant FP
+    [NonSerialized]
+    private string value;               // FN
+}