Fix S1144 FP: Ignore Serializable members #8936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/fix-S1144-FP-Serializable-members
branch
3 times, most recently
from
0f39ac8
to
072a90a
Compare
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/fix-S1144-FP-Serializable-members
branch
from
b32e66e
to
4c31f0a
Compare
gregory-paidis-sonarsource
requested changes
Mar 22, 2024
analyzers/src/SonarAnalyzer.CSharp/Rules/UnusedPrivateMember.cs
Outdated
Show resolved
Hide resolved
| { | ||
| "Id": "S4487", | ||
| "Message": "Remove this unread private field \u0027name\u0027 or refactor the code to use its value.", | ||
| "Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/ManuallyAddedNoncompliantIssues.CS/NetFramework48/InsecureDeserialization.cs#L50", |
There was a problem hiding this comment.
Wasn't this a valid issue? I don't understand why it disappeared.
There was a problem hiding this comment.
That looks correct to me. S4487 and S1144 share the same analyzer class.
The example shows a class that has a private member that can be initialized through the constructor. Then the class can be serialized, so the private member is actually used/read. So I consider this a former FP.
| @@ -19,6 +19,7 @@ | |||
| */ | |||
|
|
|||
| using SonarAnalyzer.Common.Walkers; | |||
| using SonarAnalyzer.Json.Parsing; | |||
There was a problem hiding this comment.
Is this needed?
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/fix-S1144-FP-Serializable-members
branch
from
4e12349
to
e4a3c0b
Compare
|
|
mary-georgiou-sonarsource
deleted the
Zsolt/fix-S1144-FP-Serializable-members
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8532