S3398: Add C# description #1572
Conversation
rules/S3398/description.adoc
Outdated
| @@ -0,0 +1 @@ | |||
| When a ``++private++`` method is only invoked by an inner class, there's no reason not to move it into that class. It will still have the same access to the outer class' members, but the outer class will be clearer and less cluttered. | |||
There was a problem hiding this comment.
Up to you actually, but I would not use the word inner class, but nested class.
Nested is the standard way "types within types" are defined (c.p. https://learn.microsoft.com/en-us/dotnet/csharp/programming-guide/classes-and-structs/nested-types).
While calling them nested or inner doesn't make any difference in C#, it does in Java (where the rule was first implemented), where inner classes have a reference to the outer class this and nested classes (which are called static class) don't.
The example in the Java code shows that they actually meant inner, since Outie.this.increment(); is used. So using nested in C# would in my opinion avoid some confusion.
There was a problem hiding this comment.
Couldn't agree more. Renamed it.
|
SonarQube Quality Gate for 'rspec-tools'
|
|
SonarQube Quality Gate for 'rspec-frontend'
|
|
SonarQube Quality Gate for 'rspec-tools'
|
|
SonarQube Quality Gate for 'rspec-frontend'
|
SonarSource/sonar-dotnet#6706