Improve S3398: Fix code smells #6827
Conversation
| } | ||
|
|
||
| return firstPath[lastCommonPathIndex]; | ||
| bool NotEveryNodeIsTheSameOnLevel(int level) => |
There was a problem hiding this comment.
I don't find this clearer because it's two negations:
- NotEveryNodeIsTheSameOnLevel
!=inside Any
Also, levels refers to indeces, whereas NotEveryNodeIsTheSameOnLevel is iterating over typeHierarchyFromTopToBottom
But NotEveryNodeIsTheSameOnLevel is called on levels
There's a lot of indirection in here. levels.Do(Action) actually iterates on a different data structure, using the indeces inside levels
There was a problem hiding this comment.
Reverted it. Now the only change is splitting the comment to multiple lines.
| ? minPathLength - 1 | ||
| : firstDifferingLevel - 1; |
There was a problem hiding this comment.
having -1 makes it a bit difficult to follow the logic...
there's another implicit negation here: Differ rather then Common in the name of the method: LowestCommonAncestorOrSelf
So the method is named Common, but the logic inside is looking for Different
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
Fixes #6706
RSPEC PR