Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin to ignore ActionMailer::Preview classes #504

Merged
merged 1 commit into from Feb 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/spoom/deadcode/plugins.rb
Expand Up @@ -5,6 +5,7 @@

require_relative "plugins/actionpack"
require_relative "plugins/active_job"
require_relative "plugins/action_mailer_preview"
require_relative "plugins/action_mailer"
require_relative "plugins/active_model"
require_relative "plugins/active_record"
Expand Down
19 changes: 19 additions & 0 deletions lib/spoom/deadcode/plugins/action_mailer_preview.rb
@@ -0,0 +1,19 @@
# typed: strict
# frozen_string_literal: true

module Spoom
module Deadcode
module Plugins
class ActionMailerPreview < Base
extend T::Sig

ignore_classes_inheriting_from("ActionMailer::Preview")

sig { override.params(indexer: Indexer, definition: Definition).void }
def on_define_method(indexer, definition)
definition.ignored! if indexer.nesting_class_superclass_name == "ActionMailer::Preview"
end
end
end
end
end
56 changes: 56 additions & 0 deletions test/spoom/deadcode/plugins/action_mailer_preview_test.rb
@@ -0,0 +1,56 @@
# typed: true
# frozen_string_literal: true

require "test_with_project"
require "helpers/deadcode_helper"

module Spoom
module Deadcode
module Plugins
class ActionMailerPreviewTest < TestWithProject
include Test::Helpers::DeadcodeHelper

def test_action_mailer_preview_ignore_direct_inheritance
@project.write!("test/mailers/previews/my_mailer_preview.rb", <<~RB)
class MyMailerPreview < ActionMailer::Preview
def my_email_preview_method; end

private

def some_unused_private_method; end
end

class MyOtherMailerPreview < ::ActionMailer::Preview; end
Korri marked this conversation as resolved.
Show resolved Hide resolved

class MyDirectInheritanceMailerPreview < ActionMailer::Preview; end
class MyIndirectInheritanceMailerPreview < MyDirectInheritanceMailerPreview; end

class Foo
def bar; end
end
RB

index = index_with_plugins
assert_ignored(index, "MyMailerPreview")
Korri marked this conversation as resolved.
Show resolved Hide resolved
assert_ignored(index, "MyOtherMailerPreview")
assert_ignored(index, "my_email_preview_method")
# refute_ignored(index, "some_unused_private_method") ideally we'd want this, but seems tricky to do
Korri marked this conversation as resolved.
Show resolved Hide resolved
# assert_ignored(index, "MyIndirectInheritanceMailerPreview") ideally we'd want this, but seems tricky to do
refute_ignored(index, "Foo")
refute_ignored(index, "bar")

# Document current less then ideal behavior:
assert_ignored(index, "some_unused_private_method")
refute_ignored(index, "MyIndirectInheritanceMailerPreview")
end

private

sig { returns(Index) }
def index_with_plugins
deadcode_index(plugins: [ActionMailerPreview.new])
end
end
end
end
end