Add plugin to ignore ActionMailer::Preview classes #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
reviewed
Feb 2, 2024
Korri
force-pushed
the
action-mailer-preview-plugin
branch
3 times, most recently
from
cd64957
to
7f74d3f
Compare
vinistock
reviewed
Feb 5, 2024
Korri
force-pushed
the
action-mailer-preview-plugin
branch
from
7f74d3f
to
99aac22
Compare
vinistock
approved these changes
Feb 5, 2024
New plugin that ingores all methods inside ActionMailer::Preview classes as they are all automatically made available by Rails in the previwer, but never otherwise referenced.
Korri
force-pushed
the
action-mailer-preview-plugin
branch
from
99aac22
to
4f0ff67
Compare
Morriar
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New plugin that ignores all methods inside
ActionMailer::Previewclasses as they are all automatically made available by Rails in the previewer, but never otherwise referenced.This won't work for classes multiple levels of inheriting down, but that's a limitation of
spoonright now.Created 2 follow up issues:
publicspecifically at least) #506