Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing files to gemspec & bump version to 2.15.1 #615

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Add missing files to gemspec & bump version to 2.15.1 #615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70a48d5
Add missing files to `gemspec`
sambostock Feb 15, 2024
70399a5
Bump gem version to `2.15.1`
sambostock Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
rubocop-shopify (2.15.0)
rubocop-shopify (2.15.1)
rubocop (~> 1.51)

GEM
Expand Down
4 changes: 2 additions & 2 deletions rubocop-shopify.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
Gem::Specification.new do |s|
s.platform = Gem::Platform::RUBY
s.name = "rubocop-shopify"
s.version = "2.15.0"
s.version = "2.15.1"
s.summary = "Shopify's style guide for Ruby."
s.description = "Gem containing the rubocop.yml config that corresponds to " \
"the implementation of the Shopify's style guide for Ruby."
Expand All @@ -14,7 +14,7 @@ Gem::Specification.new do |s|
s.email = "gems@shopify.com"
s.homepage = "https://shopify.github.io/ruby-style-guide/"

s.files = ["rubocop.yml", "rubocop-cli.yml", "LICENSE.md"]
s.files = Dir["rubocop*.yml", "lib/**/*", "LICENSE.md", "README.md"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach was copied from https://github.com/Shopify/maintenance_tasks/blob/3971b9baa34a0eecc94078ac15d76cc61504a75b/maintenance_tasks.gemspec#L20

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this technically causes lib/tasks/config.rake to be included as well, but that doesn't seem to be a problem if nothing is looking for it.


s.metadata = {
"source_code_uri" => "https://github.com/Shopify/ruby-style-guide/tree/v#{s.version}",
Expand Down