New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing files to gemspec & bump version to 2.15.1
#615
Conversation
2.15.0 is broken because we're failing to include the backport patch which we try to `require` at the top of `rubocop.yml`. This updates the `gempspec` to include all ruby files under `lib`, as well as the `README.md`. It also switches to use a wildcard to match the `rubocop.yml` and `rubocop-cli.yml` files, which will be useful when we add extension configs.
b0779a5
to
70399a5
Compare
@@ -14,7 +14,7 @@ Gem::Specification.new do |s| | |||
s.email = "gems@shopify.com" | |||
s.homepage = "https://shopify.github.io/ruby-style-guide/" | |||
|
|||
s.files = ["rubocop.yml", "rubocop-cli.yml", "LICENSE.md"] | |||
s.files = Dir["rubocop*.yml", "lib/**/*", "LICENSE.md", "README.md"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach was copied from https://github.com/Shopify/maintenance_tasks/blob/3971b9baa34a0eecc94078ac15d76cc61504a75b/maintenance_tasks.gemspec#L20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this technically causes lib/tasks/config.rake
to be included as well, but that doesn't seem to be a problem if nothing is looking for it.
Thanks for getting this fix in so quickly 🙌 |
This was missed because testing pulled the gem from the git repo, rather than a published version, which clones the entire repo directory structure, ignoring |
2.15.0 is broken because we're failing to include the backport patch which we try to
require
at the top ofrubocop.yml
.This updates the
gempspec
to include all ruby files underlib
, as well as theREADME.md
. It also switches to use a wildcard to match therubocop.yml
andrubocop-cli.yml
files, which will be useful when we add extension configs.It also bumps the gem version so we can publish the fix.