Add missing files to gemspec & bump version to 2.15.1
#615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.15.0 is broken because we're failing to include the backport patch which we try to `require` at the top of `rubocop.yml`. This updates the `gempspec` to include all ruby files under `lib`, as well as the `README.md`. It also switches to use a wildcard to match the `rubocop.yml` and `rubocop-cli.yml` files, which will be useful when we add extension configs.
sambostock
force-pushed
the
add-missing-files-to-gemspec
branch
from
b0779a5
to
70399a5
Compare
sambostock
commented
Feb 15, 2024
| @@ -14,7 +14,7 @@ Gem::Specification.new do |s| | |||
| s.email = "gems@shopify.com" | |||
| s.homepage = "https://shopify.github.io/ruby-style-guide/" | |||
|
|
|||
| s.files = ["rubocop.yml", "rubocop-cli.yml", "LICENSE.md"] | |||
| s.files = Dir["rubocop*.yml", "lib/**/*", "LICENSE.md", "README.md"] | |||
There was a problem hiding this comment.
This approach was copied from https://github.com/Shopify/maintenance_tasks/blob/3971b9baa34a0eecc94078ac15d76cc61504a75b/maintenance_tasks.gemspec#L20
There was a problem hiding this comment.
It looks like this technically causes lib/tasks/config.rake to be included as well, but that doesn't seem to be a problem if nothing is looking for it.
nunosilva800
approved these changes
Feb 15, 2024
ghost
approved these changes
Feb 15, 2024
|
Thanks for getting this fix in so quickly 🙌 |
|
This was missed because testing pulled the gem from the git repo, rather than a published version, which clones the entire repo directory structure, ignoring |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.15.0 is broken because we're failing to include the backport patch which we try to
requireat the top ofrubocop.yml.This updates the
gempspecto include all ruby files underlib, as well as theREADME.md. It also switches to use a wildcard to match therubocop.ymlandrubocop-cli.ymlfiles, which will be useful when we add extension configs.It also bumps the gem version so we can publish the fix.