Bump rubocop from 1.57.1 to 1.59.0 #593
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.57.1 to 1.59.0. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.57.1...v1.59.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Rather than repeat `Gem::Version.new(...)` every time we want to check a version, we can extract a variable.
sambostock
force-pushed
the
dependabot/bundler/rubocop-1.59.0
branch
from
1756fd9
to
e4452a4
Compare
github-actions
bot
added
the
config change
| <% if rubocop_version >= v1_59 %> | ||
| Lint/ItWithoutArgumentsInBlock: | ||
| Enabled: true | ||
| <% end %> |
There was a problem hiding this comment.
This takes the same approach as #582, and conditionally enables the cop based on the RuboCop version, allowing us to keep the minimum version the same.
Since I realized we'd end up repeating Gem::Version.new(...) all over the place, I extracted v1.xx variables.
| Style/ArrayFirstLast: | ||
| Description: Use `arr.first` and `arr.last` instead of `arr[0]` and `arr[-1]`. | ||
| Reference: "#first-and-last" | ||
| Enabled: false | ||
| VersionAdded: '1.58' | ||
| Safe: false |
There was a problem hiding this comment.
I kept this disabled, as I don't see it being worth it given how many false positives it would have.
sambostock
force-pushed
the
dependabot/bundler/rubocop-1.59.0
branch
from
e4452a4
to
33ba911
Compare
| Lint/ItWithoutArgumentsInBlock: | ||
| Description: Checks uses of `it` calls without arguments in block. | ||
| Reference: https://bugs.ruby-lang.org/issues/18980 | ||
| Enabled: true | ||
| VersionAdded: '1.59' |
There was a problem hiding this comment.
This emulates an upcoming warning, so best to enable it and start addressing it early.
| Lint/LiteralAssignmentInCondition: | ||
| Description: Checks for literal assignments in the conditions. | ||
| Enabled: true | ||
| VersionAdded: '1.58' |
There was a problem hiding this comment.
This looks for things like
if x = trueor
if x = 123which probably meant to use == instead. Technically, there's overlap with the rule we have that enforces surrounding ( ) for assignments in conditions, but it's still possible someone could make the mistake.
| Style/SuperWithArgsParentheses: | ||
| Description: Use parentheses for `super` with arguments. | ||
| StyleGuide: "#super-with-args" | ||
| Enabled: true | ||
| VersionAdded: '1.58' |
There was a problem hiding this comment.
This seemed like a good idea, given super and super() do different things, although it may already be covered by us having parentheses enabled for method calls be default.
Bumps rubocop from 1.57.1 to 1.59.0.
Release notes
Sourced from rubocop's releases.
... (truncated)
Changelog
Sourced from rubocop's changelog.
... (truncated)
Commits
e5a164aCut 1.592912b6eUpdate Changelog3bcc171[Fix #12524] Fix a false positive forStyle/MethodCallWithArgsParentheses0daa4aaMakeStyle/MethodCallWithoutArgsParenthesesallow parenthesizeditb240a09MakeStyle/RedundantSelfallowself.ita0e1042[Fix #12526] Fix incorrect rendering typosb1bcb31[Fix #12444] Fix false positive forStyle/HashEachMethods3b0360bAdd newLint/ItWithoutArgumentsInBlockcop4e9cfccMerge pull request #12521 from koic/make_style_select_by_regexp_aware_of_safe...037c860Merge pull request #12438 from koic/fix_a_false_positive_for_lint_literal_ass...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)