Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive for Lint/LiteralAssignmentInCondition #12432

Conversation

koic
Copy link
Member

@koic koic commented Dec 1, 2023

This PR fixes the following false positive for Lint/LiteralAssignmentInCondition when using parallel assignment with splat operator:

return if do_something do |z|
  x, y = *z
end
$ bundle exec rubocop example.rb --only Lint/LiteralAssignmentInCondition
Inspecting 1 file
W

Offenses:

example.rb:2:8: W: Lint/LiteralAssignmentInCondition: Don't use literal assignment = *z
in conditional, should be == or non-literal operand.
  x, y = *z
       ^^^^

1 file inspected, 1 offense detected

This is a false positive because ruby -w doesn't warn.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic force-pushed the fix_false_positive_for_lint_literal_assignment_in_condition branch 2 times, most recently from f0db866 to 1a0c7bb Compare December 1, 2023 18:26
This PR fixes the following false positive for `Lint/LiteralAssignmentInCondition`
when using parallel assignment with splat operator in block of guard condition:

```ruby
return if do_something do |z|
  x, y = *z
end
```

```console
$ bundle exec rubocop example.rb --only Lint/LiteralAssignmentInCondition
Inspecting 1 file
W

Offenses:

example.rb:2:8: W: Lint/LiteralAssignmentInCondition: Don't use literal assignment = *z
in conditional, should be == or non-literal operand.
  x, y = *z
       ^^^^

1 file inspected, 1 offense detected
```

This is a false positive because `ruby -w` doesn't warn.
@koic koic force-pushed the fix_false_positive_for_lint_literal_assignment_in_condition branch from 1a0c7bb to 1dc0b78 Compare December 2, 2023 05:50
@koic koic merged commit 2e4ca82 into rubocop:master Dec 2, 2023
28 checks passed
@koic koic deleted the fix_false_positive_for_lint_literal_assignment_in_condition branch December 2, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant