Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Style/HashExcept aware of safe navigation operator #12446

Closed
ydakuka opened this issue Dec 2, 2023 · 0 comments · Fixed by #12451
Closed

Make Style/HashExcept aware of safe navigation operator #12446

ydakuka opened this issue Dec 2, 2023 · 0 comments · Fixed by #12451

Comments

@ydakuka
Copy link

ydakuka commented Dec 2, 2023

Describe the solution you'd like

# bad
def my_method
  { foo: 1, bar: 2, baz: 3 }&.reject { |k, _v| k == :bar }
end

Rubocop

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V
1.58.0 (using Parser 3.2.2.4, rubocop-ast 1.30.0, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.19.0
  - rubocop-factory_bot 2.24.0
  - rubocop-performance 1.19.1
  - rubocop-rails 2.22.2
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.25.0
  - rubocop-thread_safety 0.5.1
koic added a commit to koic/rubocop that referenced this issue Dec 3, 2023
@koic
[Fix rubocop#12446] Make Style/HashExcept aware of safe navigation …
fbf047e 
…operator

Fixes rubocop#12446.

This PR makes `Style/HashExcept` aware of safe navigation operator.
@koic koic mentioned this issue Dec 3, 2023
Merged
8 tasks
koic added a commit that referenced this issue Dec 3, 2023
@koic
Merge pull request #12451 from koic/make_style_hash_except_aware_of_s…
fcc5c43 
…afe_navigation_operator

[Fix #12446] Make `Style/HashExcept` aware of safe navigation operator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #12446] Make Style/HashExcept aware of safe navigation operator koic/rubocop
1 participant
@ydakuka