Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 1.51.0 to 1.52.0 #544

Merged
merged 4 commits into from Jun 20, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 5, 2023

Bumps rubocop from 1.51.0 to 1.52.0.

Release notes

Sourced from rubocop's releases.

RuboCop 1.52

New features

Bug fixes

  • #11890: Fix a false negative for Lint/RedundantSafeNavigation when &. is used for to_d. (@​koic)
  • #11880: Fix a false positive for Style/ExactRegexpMatch when using literal with quantifier in regexp. (@​koic)
  • #11902: Fix a false positive for Style/RequireOrder when single-quoted string and double-quoted string are mixed. (@​koic)
  • #11879: Fix a false positive for Style/SelectByRegexp when Ruby 2.2 or lower analysis. (@​koic)
  • #11891: Fix Style/AccessorGrouping to accept macros separated from accessors by space. (@​fatkodima)
  • #11905: Fix an error for Lint/UselessAssignment when a variable is assigned with rest assignment and unreferenced. (@​koic)
  • #11899: Fix an incorrect autocorrect for Style/SingleLineMethods when using Ruby 3.0 and Style/EndlessMethod is disabled. (@​koic)
  • #11884: Make rubocop -V display rubocop-factory_bot version when using it. (@​koic)
  • #11893: Fix a false positive for Lint/InheritException when inheriting Exception with omitted namespace. (@​koic)
  • #11898: Fix offences in calls inside blocks with braces for Style/MethodCallWithArgsParentheses with omit_parentheses enforced style. (@​gsamokovarov)
  • #11857: Server mode: only read $stdin when -s or --stdin argument provided. (@​naveg)
Changelog

Sourced from rubocop's changelog.

1.52.0 (2023-06-02)

New features

Bug fixes

  • #11890: Fix a false negative for Lint/RedundantSafeNavigation when &. is used for to_d. ([@​koic][])
  • #11880: Fix a false positive for Style/ExactRegexpMatch when using literal with quantifier in regexp. ([@​koic][])
  • #11902: Fix a false positive for Style/RequireOrder when single-quoted string and double-quoted string are mixed. ([@​koic][])
  • #11879: Fix a false positive for Style/SelectByRegexp when Ruby 2.2 or lower analysis. ([@​koic][])
  • #11891: Fix Style/AccessorGrouping to accept macros separated from accessors by space. ([@​fatkodima][])
  • #11905: Fix an error for Lint/UselessAssignment when a variable is assigned with rest assignment and unreferenced. ([@​koic][])
  • #11899: Fix an incorrect autocorrect for Style/SingleLineMethods when using Ruby 3.0 and Style/EndlessMethod is disabled. ([@​koic][])
  • #11884: Make rubocop -V display rubocop-factory_bot version when using it. ([@​koic][])
  • #11893: Fix a false positive for Lint/InheritException when inheriting Exception with omitted namespace. ([@​koic][])
  • #11898: Fix offences in calls inside blocks with braces for Style/MethodCallWithArgsParentheses with omit_parentheses enforced style. ([@​gsamokovarov][])
  • #11857: Server mode: only read $stdin when -s or --stdin argument provided. ([@​naveg][])
Commits
  • 93a3783 Cut 1.52
  • 727967f Update Changelog
  • 41fa2aa Server mode: only read $stdin when -s or --stdin argument provided
  • a01fd9c Add new Style/RedundantArrayConstructor cop
  • 356fc46 [Fix #11908] Support AllowedReceivers for Style/CollectionMethods
  • 713e7da Remove a redundant SafeAutoCorrect: false config
  • 172cc75 Merge pull request #11907 from koic/fix_an_error_for_lint_useless_assignment
  • 63ede93 [Fix #11905] Fix an error for Lint/UselessAssignment
  • 1884a46 Merge pull request #11902 from koic/fix_a_false_positive_for_style_require_order
  • db9e469 Fix a false positive for Style/RequireOrder
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner June 5, 2023 15:56
@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Jun 5, 2023
@github-actions github-actions bot added the config change Changes the Rubocop config by enabling, disabling, or reconfiguring one or many cops label Jun 5, 2023
@rafaelfranca
Copy link
Member

Three cops were enabled, mostly to remove unnecessary code in our codebases.

Style/RedundantArrayConstructor:
https://docs.rubocop.org/rubocop/cops_style.html#styleredundantarrayconstructor

Style/RedundantFilterChain:
https://docs.rubocop.org/rubocop/cops_style.html#styleredundantfilterchain

Style/RedundantRegexpConstructor:
https://docs.rubocop.org/rubocop/cops_style.html#styleredundantregexpconstructor

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 12, 2023

A newer version of rubocop exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

dependabot bot and others added 4 commits June 19, 2023 18:50
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.51.0 to 1.52.0.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.51.0...v1.52.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
This automated commit dumps the contents of the full RuboCop config.
[dependabot skip]
@rafaelfranca rafaelfranca force-pushed the dependabot/bundler/rubocop-1.52.0 branch from 4a65807 to 6b0d109 Compare June 19, 2023 18:50
@rafaelfranca rafaelfranca merged commit 0cf1914 into main Jun 20, 2023
21 checks passed
@rafaelfranca rafaelfranca deleted the dependabot/bundler/rubocop-1.52.0 branch June 20, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config change Changes the Rubocop config by enabling, disabling, or reconfiguring one or many cops dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant