Add ComparisonsThreshold config option to Style/MultipleComparison
#11873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
May 13, 2023
config/default.yml
Outdated
| @@ -4374,6 +4374,7 @@ Style/MultipleComparison: | |||
| VersionAdded: '0.49' | |||
| VersionChanged: '1.1' | |||
| AllowMethodComparison: true | |||
| MinComparisonsCount: 2 | |||
There was a problem hiding this comment.
I'd name this "AllowedComparisonsCount" or "ThresholdComparisonsCount". I don't think that "Min" is the best term in the context. Perhaps the word "count" is a bit redundant.
There was a problem hiding this comment.
(obviously the default value would be different depending on the exact name chosen)
There was a problem hiding this comment.
Changed to ComparisonsThreshold. Let me know what you think.
fatkodima
force-pushed
the
multiple_comparison-min_comparisons_count
branch
from
d3f89bf
to
1252dad
Compare
|
Looks good to me. Thanks! |
fatkodima
changed the title
MinComparisonsCount config option to Style/MultipleComparisonComparisonsThreshold config option to Style/MultipleComparison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to use
Style/MultipleComparison, but only when at least 3 comparisons are made. It enforces this style when there are 2. Personally, I do not see much benefit for myself from this in most of the cases. So I made this value configurable, while preserving the original value of 2.