Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 1.51.0 to 1.52.0 #544

Merged
merged 4 commits into from
Jun 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ PATH
remote: .
specs:
rubocop-shopify (2.14.0)
rubocop (~> 1.51)
rubocop (~> 1.52)

GEM
remote: https://rubygems.org/
Expand All @@ -27,7 +27,7 @@ GEM
rake (13.0.6)
regexp_parser (2.8.0)
rexml (3.2.5)
rubocop (1.51.0)
rubocop (1.52.0)
json (~> 2.3)
parallel (~> 1.10)
parser (>= 3.2.0.0)
Expand All @@ -37,7 +37,7 @@ GEM
rubocop-ast (>= 1.28.0, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.28.1)
rubocop-ast (1.29.0)
parser (>= 3.2.1.0)
ruby-progressbar (1.13.0)
unicode-display_width (2.4.2)
Expand Down
2 changes: 1 addition & 1 deletion rubocop-shopify.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ Gem::Specification.new do |s|

s.required_ruby_version = ">= 2.7.0"

s.add_dependency("rubocop", "~> 1.51")
s.add_dependency("rubocop", "~> 1.52")
end
9 changes: 9 additions & 0 deletions rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -703,6 +703,9 @@ Style/RandomWithOffset:
Style/RedundantArgument:
Enabled: false

Style/RedundantArrayConstructor:
Enabled: true

Style/RedundantAssignment:
Enabled: false

Expand All @@ -727,6 +730,9 @@ Style/RedundantFetchBlock:
Style/RedundantFileExtensionInRequire:
Enabled: false

Style/RedundantFilterChain:
Enabled: true

Style/RedundantHeredocDelimiterQuotes:
Enabled: true

Expand All @@ -739,6 +745,9 @@ Style/RedundantLineContinuation:
Style/RedundantRegexpCharacterClass:
Enabled: false

Style/RedundantRegexpConstructor:
Enabled: true

Style/RedundantRegexpEscape:
Enabled: false

Expand Down
20 changes: 18 additions & 2 deletions test/fixtures/full_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1847,10 +1847,9 @@ Lint/UselessRuby2Keywords:
Lint/UselessSetterCall:
Description: Checks for useless setter call to a local variable.
Enabled: true
SafeAutoCorrect: false
Safe: false
VersionAdded: '0.13'
VersionChanged: '1.2'
Safe: false
Lint/UselessTimes:
Description: Checks for useless `Integer#times` calls.
Enabled: false
Expand Down Expand Up @@ -2499,6 +2498,7 @@ Style/CollectionCompact:
Safe: false
VersionAdded: '1.2'
VersionChanged: '1.3'
AllowedReceivers: []
Style/CollectionMethods:
Description: Preferred collection methods.
StyleGuide: "#map-find-select-reduce-include-size"
Expand Down Expand Up @@ -3297,6 +3297,7 @@ Style/MultipleComparison:
VersionAdded: '0.49'
VersionChanged: '1.1'
AllowMethodComparison: true
ComparisonsThreshold: 2
Style/MutableConstant:
Description: Do not assign mutable objects to constants.
Enabled: false
Expand Down Expand Up @@ -3624,6 +3625,10 @@ Style/RedundantArgument:
split: " "
chomp: "\n"
chomp!: "\n"
Style/RedundantArrayConstructor:
Description: Checks for the instantiation of array using redundant `Array` constructor.
Enabled: true
VersionAdded: '1.52'
Style/RedundantAssignment:
Description: Checks for redundant assignment before returning.
Enabled: false
Expand Down Expand Up @@ -3680,6 +3685,12 @@ Style/RedundantFileExtensionInRequire:
StyleGuide: "#no-explicit-rb-to-require"
Enabled: false
VersionAdded: '0.88'
Style/RedundantFilterChain:
Description: Identifies usages of `any?`, `empty?`, `none?` or `one?` predicate
methods chained to `select`/`filter`/`find_all` and change them to use predicate
method instead.
Enabled: true
VersionAdded: '1.52'
Style/RedundantFreeze:
Description: Checks usages of Object#freeze on immutable objects.
Enabled: true
Expand Down Expand Up @@ -3719,6 +3730,11 @@ Style/RedundantRegexpCharacterClass:
Description: Checks for unnecessary single-element Regexp character classes.
Enabled: false
VersionAdded: '0.85'
Style/RedundantRegexpConstructor:
Description: Checks for the instantiation of regexp using redundant `Regexp.new`
or `Regexp.compile`.
Enabled: true
VersionAdded: '1.52'
Style/RedundantRegexpEscape:
Description: Checks for redundant escapes in Regexps.
Enabled: false
Expand Down