Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Text] Undeprecate heading2xl variant #11811

Merged
merged 5 commits into from
Apr 2, 2024
Merged

[Text] Undeprecate heading2xl variant #11811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2d6b293
Undeprecate Text heading2xl variant
lgriffee Apr 1, 2024
be1b15d
Update .changeset/green-laws-crash.md
lgriffee Apr 1, 2024
7bdb4f7
Update doc site
lgriffee Apr 1, 2024
620b791
Update heading3xl replacement value
lgriffee Apr 1, 2024
2b5d9b2
Merge branch 'text-deprecation-update' of https://github.com/Shopify/…
lgriffee Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/green-laws-crash.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@shopify/polaris': patch
'polaris.shopify.com': patch
---

Undeprecated `heading2xl` variant in `Text` component
3 changes: 1 addition & 2 deletions polaris-react/src/components/Text/Text.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,7 @@ type Tone =
type TextDecorationLine = 'line-through';

const deprecatedVariants: {[V in Variant]?: Variant} = {
heading2xl: 'headingXl',
heading3xl: 'headingXl',
heading3xl: 'heading2xl',
};
export interface TextProps {
/** Adjust horizontal alignment of text */
Expand Down
2 changes: 1 addition & 1 deletion polaris.shopify.com/pages/components/[group]/[component]/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ const componentUnionTypeDeprecations: {
};
} = {
Text: {
Variant: ['heading2xl', 'heading3xl'],
Variant: ['heading3xl'],
},
};

Expand Down