Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Text] Undeprecate heading2xl variant #11811

Merged
merged 5 commits into from Apr 2, 2024
Merged

Conversation

lgriffee
Copy link
Member

@lgriffee lgriffee commented Apr 1, 2024

WHY are these changes introduced?

Part of https://github.com/Shopify/polaris-internal/issues/1529

WHAT is this pull request doing?

Undeprecates the heading2xl variant since it will be kept in the next major version for mobile purposes.

@lgriffee lgriffee self-assigned this Apr 1, 2024
@lgriffee lgriffee added the #gsd:40131 Polaris Responsive Text Styles label Apr 1, 2024
@lgriffee lgriffee marked this pull request as ready for review April 1, 2024 19:52
Copy link
Member

@alex-page alex-page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some documentation of when to use these variants to polaris.shopify.com? It could be in this PR or in a follow up.

@sam-b-rose
Copy link
Member

Can we add some documentation of when to use these variants to polaris.shopify.com?

Yes, working on these in a separate PR 👍

@lgriffee lgriffee merged commit 9aea673 into main Apr 2, 2024
14 checks passed
@lgriffee lgriffee deleted the text-deprecation-update branch April 2, 2024 21:18
sam-b-rose pushed a commit that referenced this pull request Apr 4, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-icons@8.10.0

### Minor Changes

- [#11816](#11816)
[`4b730c84d`](4b730c8)
Thanks [@dGoligorsky](https://github.com/dGoligorsky)! - Added some
icons for image editing

### Patch Changes

- [#11825](#11825)
[`fd5b31d59`](fd5b31d)
Thanks [@ryanwilsonperkin](https://github.com/ryanwilsonperkin)! - Add
missing peer dependency on React

## @shopify/polaris@12.26.0

### Minor Changes

- [#11785](#11785)
[`2a2f635ba`](2a2f635)
Thanks [@mrcthms](https://github.com/mrcthms)! - Added the
`defaultPaginatedSelectAllText` prop to `IndexTable` to support
customizing the label of the checkbox in the header that selects all
rows across pages when the table `hasMoreItems`

### Patch Changes

- [#11833](#11833)
[`810532c58`](810532c)
Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Revert responsive
text style updates


- [#11810](#11810)
[`66dc0392a`](66dc039)
Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed Shift +
click selection of `IndexTable.Row` not working in Firefox


- [#11811](#11811)
[`9aea67322`](9aea673)
Thanks [@lgriffee](https://github.com/lgriffee)! - Undeprecated
`heading2xl` variant in `Text` component


- [#11817](#11817)
[`936765c92`](936765c)
Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - [IndexTable]
Initially hide the scrollbar and update scrollbar padding


- [#11819](#11819)
[`35eb10c4f`](35eb10c)
Thanks [@kyledurand](https://github.com/kyledurand)! - Added multi
select functionality to AlphaPicker

- Updated dependencies
\[[`fd5b31d59`](fd5b31d),
[`4b730c84d`](4b730c8)]:
    -   @shopify/polaris-icons@8.10.0

## @shopify/polaris-migrator@0.28.6

### Patch Changes

- [#11813](#11813)
[`c49809998`](c498099)
Thanks [@lgriffee](https://github.com/lgriffee)! - Removed `Text`
`heading2xl` and associated tokens from v14 font migration

## polaris.shopify.com@0.67.2

### Patch Changes

- [#11796](#11796)
[`c8dc01330`](c8dc013)
Thanks [@sarahill](https://github.com/sarahill)! - Updated common action
pattern guidance


- [#11811](#11811)
[`9aea67322`](9aea673)
Thanks [@lgriffee](https://github.com/lgriffee)! - Undeprecated
`heading2xl` variant in `Text` component

- Updated dependencies
\[[`fd5b31d59`](fd5b31d),
[`810532c58`](810532c),
[`66dc0392a`](66dc039),
[`9aea67322`](9aea673),
[`4b730c84d`](4b730c8),
[`2a2f635ba`](2a2f635),
[`936765c92`](936765c),
[`35eb10c4f`](35eb10c)]:
    -   @shopify/polaris-icons@8.10.0
    -   @shopify/polaris@12.26.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
### WHY are these changes introduced?

Part of https://github.com/Shopify/polaris-internal/issues/1529

### WHAT is this pull request doing?

Undeprecates the `heading2xl` variant since it will be kept in the next
major version for mobile purposes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#gsd:40131 Polaris Responsive Text Styles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants