Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to redispy 4.1.3 (min python 3.6) #154

Merged
merged 13 commits into from Feb 13, 2022
Merged

Conversation

MeirShpilraien
Copy link
Collaborator

@MeirShpilraien MeirShpilraien commented Feb 3, 2022

Moved to redispy 4.1.3 and add tls-passphrase option

The PR changes minimum python supported version to 3.6

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestions. Great PR - surgical.

chayim
chayim previously approved these changes Feb 8, 2022
@gkorland gkorland changed the title Moved to redispy 4.2 Upgrade to redispy 4.1.3 Feb 8, 2022
@gkorland gkorland changed the title Upgrade to redispy 4.1.3 Upgrade to redispy 4.1.3 (supports python 3.6) Feb 8, 2022
@gkorland gkorland requested a review from chayim February 8, 2022 07:49
@gkorland gkorland changed the title Upgrade to redispy 4.1.3 (supports python 3.6) Upgrade to redispy 4.1.3 (min python 3.6) Feb 8, 2022
@lgtm-com
Copy link

lgtm-com bot commented Feb 8, 2022

This pull request fixes 1 alert when merging fb1e7f2 into 83f2327 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Feb 8, 2022

This pull request fixes 1 alert when merging 801d805 into 83f2327 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2022

Codecov Report

Merging #154 (85a371c) into master (83f2327) will decrease coverage by 2.53%.
The diff coverage is 65.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
- Coverage   36.66%   34.13%   -2.54%     
==========================================
  Files          17       17              
  Lines        2168     2171       +3     
==========================================
- Hits          795      741      -54     
- Misses       1373     1430      +57     
Flag Coverage Δ
unittests 34.13% <65.00%> (-2.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
RLTest/__main__.py 0.00% <0.00%> (ø)
RLTest/redis_enterprise_cluster.py 26.43% <ø> (-0.84%) ⬇️
RLTest/redis_std.py 63.36% <66.66%> (+0.02%) ⬆️
RLTest/redis_cluster.py 72.54% <69.23%> (+2.87%) ⬆️
RLTest/env.py 57.44% <100.00%> (+0.11%) ⬆️
RLTest/Enterprise/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
RLTest/Enterprise/Dmc.py 0.00% <0.00%> (-35.49%) ⬇️
RLTest/Enterprise/EnterpriseClusterEnv.py 0.00% <0.00%> (-21.88%) ⬇️
RLTest/Enterprise/CcsMock.py 0.00% <0.00%> (-16.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83f2327...85a371c. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Feb 13, 2022

This pull request fixes 1 alert when merging 0ce559a into 83f2327 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Feb 13, 2022

This pull request fixes 1 alert when merging 85a371c into 83f2327 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@chayim chayim merged commit cb887ff into master Feb 13, 2022
@chayim chayim deleted the Moved_to_redispy_4.2 branch February 13, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants