Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use ValueError instead of assert on argument checks #164

Merged
merged 2 commits into from Feb 25, 2024
Merged

fix: use ValueError instead of assert on argument checks #164

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb74c44
fix: use ValueError instead of `assert` on argument checks
chenpan321 Feb 24, 2024
a668650
Update merge_lora_into_ggml.py
saharNooby Feb 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 8 additions & 4 deletions python/merge_lora_into_ggml.py
View file
Open in desktop
Expand Up @@ -47,7 +47,8 @@ def main() -> None:

arch_version: str = args.rwkv_arch_version

assert arch_version == 'v4' or arch_version == 'v5.1' or arch_version == 'v5.2', f'Invalid RWKV architecture version {arch_version}'
if not (arch_version == 'v4' or arch_version == 'v5.1' or arch_version == 'v5.2'):
raise ValueError(f'Invalid RWKV architecture version {arch_version}')

print(f'Reading {args.lora_path}')

Expand All @@ -59,9 +60,12 @@ def main() -> None:
# noinspection PyTypeChecker
header: Tuple[int, int, int, int, int, int] = struct.unpack('=iiiiii', in_file.read(6 * 4))

assert header[0] == 0x67676d66, 'Invalid magic value'
assert 100 <= header[1] <= 101, 'Invalid version number'
assert header[5] == 0 or header[5] == 1, 'Only FP32 and FP16 models are supported'
if header[0] != 0x67676d66:
raise ValueError(f'Invalid magic value {header[0]:x}')
if not (100 <= header[1] <= 101):
raise ValueError(f'Invalid version number {header[1]}')
if not (header[5] == 0 or header[5] == 1):
raise ValueError('Only FP32 and FP16 models are supported')

out_file.write(struct.pack('=iiiiii', *header))

Expand Down