Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use ValueError instead of assert on argument checks #164

Merged
merged 2 commits into from Feb 25, 2024

Commits on Feb 24, 2024

  1. fix: use ValueError instead of assert on argument checks

    Program should always fail if arch_version or program format does not satisfy the preconditions in the program.
    However, the file merge_lora_into_ggml.py uses assert statements, sometimes being ignored under high optimization level.
    We uses if-statements here, where those preconditions would always execute, whether the environment enable assert stateuements or not.
    
    Signed-off-by: Pan Chen <chenpan321@qq.com>
    chenpan321 committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    cb74c44 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2024

  1. Configuration menu
    Copy the full SHA
    a668650 View commit details
    Browse the repository at this point in the history