New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update doctests that were not being run until a recent pytest bugfix #2332
Conversation
Thank you for submitting a pull request (PR) to PlasmaPy! ✨ The future of the project depends on contributors like you, so we deeply appreciate it! 🌱 Our contributor guide has information on:
The bottom of this page shows several checks that are run for every PR. Don't worry if something broke! We break stuff all the time. 😺 Click on "Details" to learn why a check didn't pass. Please also feel free to ask for help. We do that all the time as well. 🌸 You can find us in our chat room or weekly community meeting & office hours. Here are some tips:
If this PR is marked as ready for review, someone should stop by to provide a code review and offer suggestions soon. ✅ If you don't get a review within a few days, please feel free to send us a reminder. Please also use SI units within PlasmaPy, except when there is strong justification otherwise or in some examples. We thank you once again! |
Okay, the reason why it started failing in all of the above is because pytest was skipping doctests if something was decorated with At times like these, I'm glad I spent a couple hours a few years ago setting up an RSS feed of PyPI releases for pretty much every package that PlasmaPy depends on...yeesh. Being able to see the changes in |
# Add Sphinx extension module names here. When extensions are removed or | ||
# added, please update the corresponding section in docs/doc_guide.rst. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only substantive change to this file is rewording this comment. Otherwise, I was just moving things around.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2332 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 100 100
Lines 8567 8567
=======================================
Hits 8426 8426
Misses 141 141
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR fixes a few doctests that just started failing.
One thing that's strange... The doctests are now failing both for the newly pinned dependencies as well as the minimal dependencies. This should not be the case.