Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: @PHP84Migration introduction #7774

Conversation

keradus
Copy link
Member

@keradus keradus commented Jan 24, 2024

ref https://wiki.php.net/rfc/deprecate-implicitly-nullable-types

(PR not ready, some updates needed. opening as draft, to be back to it when RFC is concluded)

@keradus keradus marked this pull request as draft January 24, 2024 13:27
@julienfalque
Copy link
Member

julienfalque commented Jan 25, 2024

If the RFC is accepted, we'll also have to deprecate nullable_type_declaration_for_default_null_value at some point.

…laration_for_default_null_value_84

# Conflicts:
#	doc/rules/function_notation/nullable_type_declaration_for_default_null_value.rst
@keradus keradus force-pushed the nullable_type_declaration_for_default_null_value_84 branch from a3093fe to 304c183 Compare March 9, 2024 10:11
@keradus keradus changed the title feat: PHP84MigrationSet draft feat: @PHP84Migration introduce Mar 9, 2024
@keradus keradus changed the title feat: @PHP84Migration introduce feat: @PHP84Migration introduction Mar 9, 2024
@Wirone Wirone enabled auto-merge (squash) March 25, 2024 09:05
@Wirone Wirone merged commit 2091e39 into PHP-CS-Fixer:master Mar 25, 2024
25 checks passed
@coveralls
Copy link

Coverage Status

coverage: 96.035%. remained the same
when pulling dda555a on keradus:nullable_type_declaration_for_default_null_value_84
into e980ab2 on PHP-CS-Fixer:master.

@keradus keradus deleted the nullable_type_declaration_for_default_null_value_84 branch March 25, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants