Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depr: nullable_type_declaration_for_default_null_value - deprecate option that is against @PHP84Migration #7872

Merged
merged 4 commits into from Mar 13, 2024

Conversation

keradus
Copy link
Member

@keradus keradus commented Mar 9, 2024

ref #7774

@coveralls
Copy link

coveralls commented Mar 9, 2024

Coverage Status

coverage: 96.034%. remained the same
when pulling 82c8ea0 on keradus:depr
into 54e8f39 on PHP-CS-Fixer:master.

@Wirone Wirone changed the title chore: nullable_type_declaration_for_default_null_value - deprecate option that is against @PHP84Migration feat: nullable_type_declaration_for_default_null_value - deprecate option that is against @PHP84Migration Mar 12, 2024
@Wirone
Copy link
Member

Wirone commented Mar 12, 2024

FYI: I've changed chore to feat, because SemVer specifies it explicitly that deprecations in public API have to change minor version, so basically it's a feature ("net negative", but still).

@keradus
Copy link
Member Author

keradus commented Mar 12, 2024

OK that deprecation is bumping minor in SemVer.
wondering if feat category fits best, maybe we shall have dedicated depr category. we will deprecate more things soon and see them in features section of release changelog may be coubter-intuitive

@Wirone
Copy link
Member

Wirone commented Mar 12, 2024

IMHO if there's "deprecate" in the title then it's enough. For automated release notes maybe depr: or feat(depr): will be required, but we're not there yet.

@keradus
Copy link
Member Author

keradus commented Mar 13, 2024

let me go with depr variant then.

@keradus keradus changed the title feat: nullable_type_declaration_for_default_null_value - deprecate option that is against @PHP84Migration depr: nullable_type_declaration_for_default_null_value - deprecate option that is against @PHP84Migration Mar 13, 2024
@keradus keradus merged commit 47530e1 into PHP-CS-Fixer:master Mar 13, 2024
26 checks passed
@keradus keradus deleted the depr branch March 13, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants