New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improve how FQCN is handled in phpDoc #7622
Merged
keradus
merged 5 commits into
PHP-CS-Fixer:master
from
Wirone:codito/fix-fqcn-in-phpdoc
Dec 28, 2023
Merged
fix: Improve how FQCN is handled in phpDoc #7622
keradus
merged 5 commits into
PHP-CS-Fixer:master
from
Wirone:codito/fix-fqcn-in-phpdoc
Dec 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wirone
added
topic/phpdoc
PHPDoc tags, Doctrine Annotations etc.
topic/fqcn
Fully Qualified Class Name usage and conversions
labels
Dec 25, 2023
mvorisek
reviewed
Dec 25, 2023
mvorisek
reviewed
Dec 25, 2023
Wirone
force-pushed
the
codito/fix-fqcn-in-phpdoc
branch
from
December 27, 2023 01:24
691f0df
to
2d922ea
Compare
This was referenced Dec 27, 2023
keradus
reviewed
Dec 28, 2023
keradus
reviewed
Dec 28, 2023
keradus
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic/fqcn
Fully Qualified Class Name usage and conversions
topic/phpdoc
PHPDoc tags, Doctrine Annotations etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #7620 but does not fix it completely. Addresses only clear bug which was covering non-FQCNs and changing whitespace between annotation tag and its value. Configuration option for enabling/disabling handling FQCNs in phpDoc will be provided in separate PR.