Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve how FQCN is handled in phpDoc #7622

Merged
merged 5 commits into from Dec 28, 2023

Conversation

Wirone
Copy link
Member

@Wirone Wirone commented Dec 25, 2023

Relates to #7620 but does not fix it completely. Addresses only clear bug which was covering non-FQCNs and changing whitespace between annotation tag and its value. Configuration option for enabling/disabling handling FQCNs in phpDoc will be provided in separate PR.

@Wirone Wirone added topic/phpdoc PHPDoc tags, Doctrine Annotations etc. topic/fqcn Fully Qualified Class Name usage and conversions labels Dec 25, 2023
@Wirone Wirone requested a review from keradus December 25, 2023 17:28
@Wirone Wirone self-assigned this Dec 25, 2023
@coveralls
Copy link

coveralls commented Dec 25, 2023

Coverage Status

coverage: 94.804%. remained the same
when pulling 9a30e57 on Wirone:codito/fix-fqcn-in-phpdoc
into 99e3a8d on PHP-CS-Fixer:master.

@keradus keradus enabled auto-merge (squash) December 28, 2023 16:59
@keradus keradus merged commit c953b3b into PHP-CS-Fixer:master Dec 28, 2023
25 checks passed
@Wirone Wirone deleted the codito/fix-fqcn-in-phpdoc branch December 28, 2023 22:26
danog pushed a commit to zoonru/PHP-CS-Fixer that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/fqcn Fully Qualified Class Name usage and conversions topic/phpdoc PHPDoc tags, Doctrine Annotations etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants