fix: ClassDefinitionFixer for anonymous class with phpdoc/attribute on separate line #7546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
changed the title
mvorisek
force-pushed
the
fix_phpdoc_in_anony_class_format_7541
branch
from
0236465
to
4fcb2a6
Compare
mvorisek
force-pushed
the
fix_phpdoc_in_anony_class_format_7541
branch
2 times, most recently
from
3aced95
to
5d7d23d
Compare
mvorisek
force-pushed
the
fix_phpdoc_in_anony_class_format_7541
branch
from
5d7d23d
to
85cb3e3
Compare
mvorisek
force-pushed
the
fix_phpdoc_in_anony_class_format_7541
branch
from
85cb3e3
to
5972116
Compare
kubawerlos
reviewed
Dec 19, 2023
mvorisek
force-pushed
the
fix_phpdoc_in_anony_class_format_7541
branch
from
5972116
to
38f1a4b
Compare
|
@mvorisek there's no need to ping me, because I have notifications for everything in the repo, so I am aware of your PRs, but as I said before I have a holidays until January 3rd 🙂. Spending time with family, AFK. |
mvorisek
force-pushed
the
fix_phpdoc_in_anony_class_format_7541
branch
2 times, most recently
from
91fda09
to
5831ead
Compare
|
Also let's please merge this PR. And happy new year to you and your beatiful family! ❤ |
mvorisek
force-pushed
the
fix_phpdoc_in_anony_class_format_7541
branch
from
3072287
to
ee66921
Compare
|
This issue is here for more than a month. Can it be please merged soon? Thank you ❤ |
Wirone
reviewed
Jan 18, 2024
Wirone
approved these changes
Jan 29, 2024
Wirone
force-pushed
the
fix_phpdoc_in_anony_class_format_7541
branch
from
b21684c
to
6470699
Compare
|
Thanks @mvorisek 🍻! |
danog
pushed a commit
to zoonru/PHP-CS-Fixer
that referenced
this pull request
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7541