New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sphinx: 5.3.0 -> 7.2.6 #259350
sphinx: 5.3.0 -> 7.2.6 #259350
Conversation
@ofborg build python311Packages.wrapt |
Diff: sphinx-doc/sphinx@v5.3.0...v7.2.6 Changelog: https://www.sphinx-doc.org/en/master/changes.html#release-7-2-6-released-sep-13-2023 Co-authored-by: Theodore Ni <3806110+tjni@users.noreply.github.com> Co-authored-by: Anderson Torres <torres.anderson.85@protonmail.com> Co-authored-by: OTABI Tomoya <tomoya.otabi@gmail.com>
….pth This change fixes the import error reported in the following comment. It is caused by the legacy setuptools namespace. NixOS#210338 (comment)
63a2fb9
to
652fdc8
Compare
|
Hydra shows the same log for ghc: |
cc @sternenseemann for ghc We already had a patch for that iirc. Edit: Looks like that was 2278f9e, and it still gets applied. Looks like ghc is affected by the same change as libcamera: https://git.libcamera.org/libcamera/libcamera.git/commit/?id=6cb92b523bd60bd7718df134cc5b1eff51cf42e5 |
That's a new issue, I think, the patch was for 6.0 and is either applied in nixpkgs or upstreamed into GHC. I've opened https://gitlab.haskell.org/ghc/ghc/-/issues/24129 for now, since I can't look into it myself atm. |
Description of changes
Diff: sphinx-doc/sphinx@v5.3.0...v7.2.6
Changelog: https://www.sphinx-doc.org/en/master/changes.html#release-7-2-6-released-sep-13-2023
A successor to #244625
The commit 1eb8fcf adds
pythonNamespaces
to allsphinxcontrib-*
packages in order to fix the import error reported in the following comment.#210338 (comment)
This is an existing approach that fixes the legacy setuptools namespace issue that @tjni investigated.
I also picked a commit to standardize the pname, as noted in this comment.
#244625 (comment)
related PRs
cc @AndersonTorres @mweinelt @ncfavier @SuperSandro2000 @tjni
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)