Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.sphinxcontrib-wavedrom: init at 3.0.4 #264321

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

fsagbuya
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2841

@natsukium
Copy link
Member

Result of nixpkgs-review pr 264321 run on x86_64-linux 1

4 packages built:
  • python310Packages.sphinxcontrib-wavedrom
  • python310Packages.sphinxcontrib-wavedrom.dist
  • python311Packages.sphinxcontrib-wavedrom
  • python311Packages.sphinxcontrib-wavedrom.dist

Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll merge it after CI passes.

@natsukium
Copy link
Member

@ofborg build python311Packages.sphinxcontrib-wavedrom

@Janik-Haag
Copy link
Member

you don't have to do a extra ofborg build if the darwin tests seem stuck, it's just we don't have enough darwin build infra

@natsukium
Copy link
Member

natsukium commented Oct 31, 2023

If the package name in the commit message is an alias, ofborg will not start the build. So unfortunately I have to call it manually.
python3Packages is a commonly used alias, but I recommend the current python311Packages.

@Janik-Haag
Copy link
Member

hm interesting, the linux stuff build before you pinged ofborg 🤔

@natsukium natsukium merged commit 2fb4d5a into NixOS:master Nov 1, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants