Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphinx: 5.3.0 -> 7.1.2 #249230

Closed
wants to merge 1 commit into from
Closed

Conversation

AndersonTorres
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@AndersonTorres
Copy link
Member Author

AndersonTorres commented Aug 15, 2023

@ofborg build sphinx

@AndersonTorres
Copy link
Member Author

Why is this breaking?

@AndersonTorres
Copy link
Member Author

Oh no, a patch fixing that ä -> æ is needed!

@tjni
Copy link
Contributor

tjni commented Aug 16, 2023

I have been busy with another project, so I hope some WIP I had can help you get this across the finish line. There is one pretty non-obvious challenge with it. (Or, I'd love to collaborate to figure out the best way forward): #244625

@tjni
Copy link
Contributor

tjni commented Aug 22, 2023

I can see a path forward here.

First, upstream in sphinx-doc/sphinx#11495 updated and released many extensions that now use implicit namespaces, and we can try to pull those in.

For the ones that are remaining, #250830 opened my eyes to pythonNamespacesHook, which more elegantly removes the extraneous nspkg.pth files that break legacy and implicit namespaces living together.

#244625 has a record of the packages that I found were involved.

I'm currently busy trying to fix all the breakages I introduced in #248866, so it will be a couple of days before I can get to this again. If in the meantime you'd like to take it on, please be my guest!

@SuperSandro2000
Copy link
Member

closing in favor of the linked PR from tjni

@AndersonTorres AndersonTorres deleted the sphinx branch August 25, 2023 20:44
@natsukium natsukium mentioned this pull request Oct 6, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants