Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Base path functionality #155

Merged
merged 14 commits into from
Jun 20, 2023
Merged

Add Base path functionality #155

merged 14 commits into from
Jun 20, 2023
+2,446 −477

Conversation

Niels-IO
Copy link
Owner

@Niels-IO Niels-IO commented Jun 9, 2023

No description provided.

wpoynter and others added 7 commits April 27, 2023 13:08
@wpoynter
Added basePath into image path generation

Verified

This commit was signed with the committer’s verified signature.
wpoynter Will Poynter
GPG key ID: AB3BE72A7CA5B1A9
Verified
Learn about vigilant mode
2253f69
@wpoynter
Removed useRouter to make compatible with appDir in Next.js 13

Verified

This commit was signed with the committer’s verified signature.
wpoynter Will Poynter
GPG key ID: AB3BE72A7CA5B1A9
Verified
Learn about vigilant mode
dcc4752
@wpoynter @Niels-IO
Added basePath into image path generation

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
debdba5
@wpoynter @Niels-IO
Removed useRouter to make compatible with appDir in Next.js 13

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
25fa75d
@Niels-IO
BasePath works
224a2d6
@Niels-IO
Merge branch 'basePath' of https://github.com/TheFuturePlace/next-ima…
1365707 
…ge-export-optimizer into pr/137
@Niels-IO
Fix merge errors
17b7633
@Niels-IO Niels-IO changed the title Base path Add Base path functionality Jun 9, 2023
@Niels-IO
Copy link
Owner Author

Niels-IO commented Jun 9, 2023

Hi @wpoynter,
I did some work based on your PR, but I somehow had to open up this new PR. I want to add some more e2e testing functionality with the basePath option. For this, I have to figure out how to serve the generated exported files for testing purposes.

@Niels-IO Niels-IO mentioned this pull request Jun 9, 2023
Merged
3 tasks
@Niels-IO Niels-IO merged commit 5be8996 into master Jun 20, 2023
@Niels-IO Niels-IO deleted the basePath branch June 20, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Niels-IO @wpoynter