Added basePath into image path generation #137
Merged
+1,259
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Niels-IO
Great work on supporting external images. I have begun putting it to work for my statically built blog. As a final hurdle, we use a
basePath
as the blog sits within a larger site. I have begun the working of supportingbasePath
as set innext.config.js
. I am pretty sure I have got a few issues:next/router
available in the newapp
directory setup supported by Next.JS 13?Feel free to point out other things I have missed, or if my approach is going the wrong way for the package.