Added basePath into image path generation #137
Merged
+1,259
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're currently using next-image-export-organizer to optimize images for a static website built with Next.js. Thank you for publishing this helpful plugin. 😊 However, our static site is also deployed to a staging area that is available under a different We'd really appreciate if this PR could be merged soon. Is there anything I can help you with, e.g. testing or reviewing? |
|
Hi @itrich, I continued the work from @wpoynter in #155. Do you have an idea how I would be able to locally serve the files with the subPath using the https://github.com/vercel/serve package? Some kind of rewrites would have to happen, probably. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Niels-IO
Great work on supporting external images. I have begun putting it to work for my statically built blog. As a final hurdle, we use a
basePathas the blog sits within a larger site. I have begun the working of supportingbasePathas set innext.config.js. I am pretty sure I have got a few issues:next/routeravailable in the newappdirectory setup supported by Next.JS 13?Feel free to point out other things I have missed, or if my approach is going the wrong way for the package.