Rollback runTest timeout to 60 seconds, configure it with getenv #3945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit attempts to fix #3800. The first part of the fix, reverting the timeout to 60 seconds, is successful. The second part, allowing global configuration, not so much. On JVM, Native, and Node JS, it's possible to use environment variables to communicate data to the process, and it could in theory be the solution, but it doesn't seem to interoperate well with Gradle. The best attempt so far was to use this: ```kotlin tasks.withType(AbstractTestTask::class).all { if (this is ProcessForkOptions) { environment("kotlinx.coroutines.test.default_timeout", "1ms") } } ``` Unfortunately, only `jvmTest` implements `ProcessForkOptions`. Without a clear way to configure the `runTest` timeout in Gradle builds, we can't claim that this is a proper solution.
dkhalanskyjb
force-pushed
the
dk-runTest-configurable-global-timeout
branch
from
bd34f55
to
a774899
Compare
|
It looks like there is no satisfactory answer so far for any platforms other than JVM. If we merge this JVM-only solution, I'll file an issue to support this on the other platforms. |
qwwdfsad
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix #3800.
The first part of the fix, reverting the timeout to 60 seconds, is successful.
The second part, allowing global configuration, not so much.
On JVM, Native, and Node JS, it's possible to use environment variables to communicate data to the process, and it could in theory be the solution, but it doesn't seem to interoperate well with Gradle.
The best attempt so far was to use this:
Unfortunately, only
jvmTestimplementsProcessForkOptions.Without a clear way to configure the
runTesttimeout in Gradle builds, we can't claim that this is a proper solution.