-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rollback runTest timeout to 60 seconds, configure it with getenv (#3945)
This commit attempts to fix #3800. The first part of the fix, reverting the timeout to 60 seconds, is successful. The second part, allowing global configuration, is only provided for the JVM so far. On JVM, Native, and Node JS, it's possible to use environment variables to communicate data to the process, and it could in theory be the solution, but it doesn't seem to interoperate well with Gradle. The best attempt so far was to use this: ```kotlin tasks.withType(AbstractTestTask::class).all { if (this is ProcessForkOptions) { environment("kotlinx.coroutines.test.default_timeout", "1ms") } } ``` Unfortunately, only `jvmTest` implements `ProcessForkOptions`. Without a clear way to configure the `runTest` timeout in Gradle builds for all targets, we only support this via system properties on the JVM until a better mechanism appears.
- Loading branch information
1 parent
d5c0eff
commit 9a98eab
Showing
4 changed files
with
40 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters