use updating node versions in CI #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
approved these changes
Dec 5, 2022
| @@ -10,20 +10,20 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| # awaiting support for 'latest'/'lts'. https://github.com/actions/setup-node/issues/26 | |||
| node: [ '12', '14', '16', '17' ] | |||
| node: [ 'latest', 'lts/*', 'lts/-1' ] | |||
There was a problem hiding this comment.
One (small) advantage of the explicit version numbers is it matches what's in the package.json engines field. Usually they naturally get updated together (the 12 tests will fail if you update package.json but not the test matrix), but in this world these versions could keep advancing and engines could bit rot if nobody files an issue (and we don't release a breaking change but stop testing on older node versions).
One option is keeping an explicit oldest version in the matrix? Annoying if it duplicates a version, though. Maybe more important on the LH repo since it'll be testing chrome-launcher on its full version matrix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.....
okay it it looks happy now :)