Skip to content

Commit

Permalink
use updating node versions in CI (#286)
Browse files Browse the repository at this point in the history
  • Loading branch information
paulirish committed Dec 5, 2022
1 parent 8d1d85d commit c753ba0
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 14 deletions.
21 changes: 11 additions & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,20 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
# awaiting support for 'latest'/'lts'. https://github.com/actions/setup-node/issues/26
node: [ '12', '14', '16', '17' ]
node: [ 'latest', 'lts/*', 'lts/-1' ]
name: basics (node ${{ matrix.node }})

steps:
- name: git clone
uses: actions/checkout@v2
uses: actions/checkout@v3

- name: Setup node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
cache: 'yarn'

- run: yarn --frozen-lockfile
- run: yarn --frozen-lockfile --network-timeout 1000000
- run: yarn build

- run: yarn test-formatting
Expand All @@ -43,13 +43,14 @@ jobs:

steps:
- name: git clone
uses: actions/checkout@v2
uses: actions/checkout@v3

- name: Use Node.js 14.x
uses: actions/setup-node@v2
- name: Use Node.js
uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: lts/*
cache: 'yarn'

- run: yarn --frozen-lockfile
- run: yarn --frozen-lockfile --network-timeout 1000000
- run: yarn build
- run: yarn test --reporter=spec
9 changes: 5 additions & 4 deletions .github/workflows/lh-smoke.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,13 @@ jobs:

steps:
- name: git clone
uses: actions/checkout@v2
uses: actions/checkout@v3

- name: Use Node.js 14.x
uses: actions/setup-node@v1
- name: Use Node.js
uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: lts/*
cache: 'yarn'

# chrome-launcher
# This'll add lighthouse AND install chrome-launcher's deps
Expand Down

0 comments on commit c753ba0

Please sign in to comment.