Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Effect.if from crashing when first argument is not an Effect #2299

Merged
merged 4 commits into from
Mar 16, 2024

Conversation

alex-dixon
Copy link
Contributor

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Prevents Effect.if from crashing when first argument is not an Effect.

Related

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@alex-dixon alex-dixon requested a review from mikearnaldi as a code owner March 13, 2024 13:10
Copy link

changeset-bot bot commented Mar 13, 2024

🦋 Changeset detected

Latest commit: 82b504c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
effect Patch
@effect/cli Patch
@effect/experimental Patch
@effect/opentelemetry Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/platform Patch
@effect/printer-ansi Patch
@effect/printer Patch
@effect/rpc-http Patch
@effect/rpc Patch
@effect/schema Patch
@effect/typeclass Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@tim-smart tim-smart changed the title fix: Effect.if (#2271) Prevent Effect.if from crashing when first argument is not an Effect Mar 13, 2024
tim-smart and others added 2 commits March 14, 2024 10:21

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@mikearnaldi mikearnaldi merged commit 814e5b8 into Effect-TS:main Mar 16, 2024
11 of 12 checks passed
@github-actions github-actions bot mentioned this pull request Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Effect.if crashes when first arg is widened to any
3 participants