Prevent Effect.if from crashing when first argument is not an Effect (#2299)

alex-dixon · tim-smart · mikearnaldi · web-flow · commit 814e5b828f68 · 2024-03-16T16:01:08.000+01:00
Co-authored-by: Tim &lt;hello@timsmart.co&gt;
Co-authored-by: Michael Arnaldi &lt;michael.arnaldi@effectful.co&gt;
diff --git a/.changeset/wicked-apples-press.md b/.changeset/wicked-apples-press.md
@@ -0,0 +1,5 @@
+---
+"effect": patch
+---
+
+Prevent Effect.if from crashing when first argument is not an Effect
diff --git a/packages/effect/src/internal/core.ts b/packages/effect/src/internal/core.ts
@@ -952,7 +952,8 @@ export const if_ = dual<
   (self: boolean | Effect.Effect<unknown, unknown, unknown>, { onFalse, onTrue }: {
     readonly onTrue: Effect.Effect<unknown, unknown, unknown>
     readonly onFalse: Effect.Effect<unknown, unknown, unknown>
-  }) => typeof self === "boolean" ? (self ? onTrue : onFalse) : flatMap(self, (b) => (b ? onTrue : onFalse))
+    // eslint-disable-next-line no-extra-boolean-cast
+  }) => isEffect(self) ? flatMap(self, (b) => (b ? onTrue : onFalse)) : Boolean(self) ? onTrue : onFalse
 )
 
 /* @internal */

Original file line number	Diff line number	Diff line change
`@@ -952,7 +952,8 @@ export const if_ = dual<`
`952`	`952`	`(self: boolean \| Effect.Effect<unknown, unknown, unknown>, { onFalse, onTrue }: {`
`953`	`953`	`readonly onTrue: Effect.Effect<unknown, unknown, unknown>`
`954`	`954`	`readonly onFalse: Effect.Effect<unknown, unknown, unknown>`
`955`		`- }) => typeof self === "boolean" ? (self ? onTrue : onFalse) : flatMap(self, (b) => (b ? onTrue : onFalse))`
	`955`	`+ // eslint-disable-next-line no-extra-boolean-cast`
	`956`	`+ }) => isEffect(self) ? flatMap(self, (b) => (b ? onTrue : onFalse)) : Boolean(self) ? onTrue : onFalse`
`956`	`957`	`)`
`957`	`958`
`958`	`959`	`/* @internal */`