Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NPM dependencies #581

Merged
merged 1 commit into from Aug 26, 2022
Merged

Conversation

easy-dynamics-oscal-automation[bot]
Copy link
Contributor

This was generated by the "Update dependencies" workflow, primarily by running npm-check-updates and npm install.

@easy-dynamics-oscal-automation easy-dynamics-oscal-automation bot requested a review from a team August 23, 2022 12:24
@tuckerzp tuckerzp self-assigned this Aug 23, 2022
package-lock.json Outdated Show resolved Hide resolved
@easy-dynamics-oscal-automation easy-dynamics-oscal-automation bot requested a review from a team August 23, 2022 21:02
@kylelaker
Copy link
Contributor

Also, it looks like the failure above highlights an issue with the onRestError prop that we're using... somewhere we're failing to actually pass a function.

FAIL src/components/OSCALJsonEditor.test.js
  ● OSCALJsonEditor › should render as expected

    TypeError: props.onRestError is not a function



      at src/components/OSCALControlProse.js:605:23
      at src/components/oscal-utils/OSCALRestUtils.js:153:13

  ● OSCALJsonEditor › should render as expected

    TypeError: props.onRestError is not a function



      at src/components/OSCALControlProse.js:605:23
      at src/components/oscal-utils/OSCALRestUtils.js:153:13

  ● OSCALJsonEditor › should render as expected

    TypeError: props.onRestError is not a function



      at src/components/OSCALControlProse.js:605:23
      at src/components/oscal-utils/OSCALRestUtils.js:153:13

  ● OSCALJsonEditor › should render as expected

    TypeError: props.onRestError is not a function



      at src/components/OSCALControlProse.js:605:23
      at src/components/oscal-utils/OSCALRestUtils.js:153:13

  ● OSCALJsonEditor › should return JSON after clicking save

    connect ECONNREFUSED 127.0.0.1:80



  ● OSCALJsonEditor › should return JSON after clicking save

    connect ECONNREFUSED 127.0.0.1:80



  ● OSCALJsonEditor › should return JSON after clicking save

    connect ECONNREFUSED 127.0.0.1:80



  ● OSCALJsonEditor › should return JSON after clicking save

    connect ECONNREFUSED 127.0.0.1:80

This probably would have been prevented with stronger type checking. In any case, if it's trivial, we can fix it here. Otherwise, we should we probably open a separate issue.

@tuckerzp
Copy link
Contributor

It looks like while tough-cookie is still broken, they are aware of the issue and are trying to fix it. It may be best to just leave this broken for now until things are fixed on their end.

@easy-dynamics-oscal-automation easy-dynamics-oscal-automation bot requested a review from a team August 25, 2022 23:48
@tuckerzp tuckerzp merged commit 1a71322 into develop Aug 26, 2022
@tuckerzp tuckerzp deleted the automation/update-npm-dependencies branch August 26, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants