Temporarily fix npm dependency updates #586
Conversation
Due to breaking changes tracked both on tough-cookie issue #246 & jsdom issue #3419, our tests are failing. This temporarily sets tough-cookie to be version 4.0.0 so tests can pass and we can update other dependencies. We will want to revert this change whenever their issues are resolved.
|
This is going to be harder to track going forward. The workflow won't update it automatically. Who is going to monitor for the fix, test it, and apply it? Should we instead just set a non-special use domain or changing the settings for the created cookie jar, the other workarounds suggested in the issue? Also, please fix the links in the message above; they currently link to issues on this repo which isn't accurate. The structure is Unless there's a dependency we need to update, I am also okay with just not merging the dependency update PR for a few days. |
Sounds good! I was mostly just playing around with it to see if tests passed and thought I might as well make a pr. I do not feel strongly at all about whether or not we merge this in. |
Due to breaking changes tracked both on
tough-cookieissue 246 &jsdomissue 3419, our tests are failing. This temporarily sets tough-cookie
to be version 4.0.0 so tests can pass and we can update other
dependencies. We will want to revert this change whenever their issues
are resolved.
See #581 for more context.