[ramda] Use types-ramda package

[Harris-Miller]

types-ramda package is live!

The new types-ramda package is now published to npm

That package brings all the types that are defined here as @types/ramda in-house. The goal is to have more direct control and work on filling out all the missing pieces. Eventually, that repo will be migrated into the core ramda repo so types can be first-class. Until then, the plan is to just have @types/ramda re-export types-ramda until then

Changes to @types/ramda

• The index.d.ts now just re-exports all of types-ramda (all definitions were moved there)
• tools.d.ts removed except from a single common function that is still used for tests
• A lot of test assertion types were updated to support a major bump of ts-toolkit done in types-ramda

Looking for help with types-ramda!

If you would like to contribute, please check out https://github.com/ramda/types

[typescript-bot]

@Harris-Miller Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• ramda — on npm, on unpkg
  • 2 added owners: @drewwyatt, ✎@Harris-Miller

@Harris-Miller: I see that you have added yourself as an owner, are you sure you want to become an owner?

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 64939,
  "author": "Harris-Miller",
  "headCommitOid": "fc65c36a3823f886cbc3b6b6e861d0ffc4fb4186",
  "mergeBaseOid": "297f116dcdbe8382a5e2b7b6aa0324f626e6f212",
  "lastPushDate": "2023-04-11T00:58:46.000Z",
  "lastActivityDate": "2023-04-11T02:09:34.000Z",
  "mergeOfferDate": "2023-04-11T02:04:15.000Z",
  "mergeRequestDate": "2023-04-11T02:09:34.000Z",
  "mergeRequestUser": "Harris-Miller",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": true,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "ramda",
      "kind": "edit",
      "files": [
        {
          "path": "types/ramda/README.md",
          "kind": "markdown"
        },
        {
          "path": "types/ramda/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ramda/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/ramda/test/assoc-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/ramda/test/binary-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/ramda/test/constructN-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/ramda/test/converge-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/ramda/test/filter-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/ramda/test/has-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/ramda/test/ifElse-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/ramda/test/nAry-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/ramda/test/pipe-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/ramda/test/reject-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/ramda/test/tryCatch-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/ramda/tools.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "TheHandsomeCoder",
        "donnut",
        "mdekrey",
        "sbking",
        "afharo",
        "teves-castro",
        "hojberg",
        "samsonkeung",
        "angeloocana",
        "raynerd",
        "moshensky",
        "ethanresnick",
        "deftomat",
        "blimusiek",
        "biern",
        "rayhaneh",
        "rgm",
        "jottenlips",
        "minitesh",
        "krantisinh",
        "nemo108",
        "jituanlin",
        "Philippe-mills",
        "Saul-Mirone",
        "Nicholaiii",
        "LORDBABUINO",
        "couzic",
        "NEWESTERS",
        "adispring",
        "essenmitsosse"
      ],
      "addedOwners": [
        "drewwyatt",
        "harris-miller"
      ],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2023-04-11T02:03:29.000Z",
      "isMaintainer": true
    },
    {
      "type": "stale",
      "reviewer": "afharo",
      "date": "2023-04-05T08:54:41.000Z",
      "abbrOid": "fbdd304"
    }
  ],
  "mainBotCommentID": 1489530672,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @TheHandsomeCoder @donnut @mdekrey @sbking @afharo @teves-castro @hojberg @samsonkeung @angeloocana @raynerd @moshensky @ethanresnick @deftomat @blimusiek @biern @rayhaneh @rgm @jottenlips @minitesh @Krantisinh @Nemo108 @jituanlin @Philippe-mills @Saul-Mirone @Nicholaiii @LORDBABUINO @couzic @NEWESTERS @adispring @essenmitsosse — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[Harris-Miller]

@TheHandsomeCoder @donnut @mdekrey @sbking @afharo @teves-castro @hojberg @samsonkeung @angeloocana @raynerd @moshensky @ethanresnick @deftomat @blimusiek @biern @rayhaneh @rgm @jottenlips @minitesh @Krantisinh @Nemo108 @jituanlin @Philippe-mills @Saul-Mirone @Nicholaiii @LORDBABUINO @couzic @NEWESTERS @adispring @essenmitsosse

I'm looking for help over at https://github.com/ramda/types, please message me if you'd like to help!

[typescript-bot]

@Harris-Miller The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[Harris-Miller]

types-ramda@0.29.0 now in MR

[typescript-bot]

@jakebailey, @afharo Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[Harris-Miller]

Ready to merge

[Harris-Miller]

@jakebailey Hey man. This merge did a patch release and we had meant for it to do a minor release. What do I need to do to correct that?

[jakebailey]

Uh oh. I didn't realize they were set to 0.28. What we should have done was bump the types to 0.29 first, let it publish, then update them.

What we can do now is this:

• First, bump this package to 0.29, so people get the latest.
• Create a v0.28 folder and copy the old state back in with the old version, and let that publish.
• Once 0.28 is published again but with the old contents put back over, delete it again.

[jakebailey]

Rather, what we should have done was bump the version in index.d.ts, actually. No need for that waiting game. But, too late now. I am happy to do the above real quick.

[jakebailey]

I've now done this whole rigmarole.

• 0.29.0 is out, pointing to 0.29.0 of types-ramda.
• 0.28.25 is out, restoring the old contents of 0.28 before this change. 0.28.24 is the bad release; hopefully people update past it. If it turns into a problem, we can do a manual deprecation.
• The 0.28 types are deleted again.

So, we should be good. Thanks for letting me know.

[Harris-Miller]

@jakebailey Thank you so much!