Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ramda to 0.29 #65119

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Bump ramda to 0.29 #65119

merged 1 commit into from
Apr 14, 2023

Conversation

jakebailey
Copy link
Member

See: #64939 (comment)

Another PR will re-add 0.28 temporarily so that the types can be re-published.

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 14, 2023

@jakebailey Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • 🕐 Continuous integration tests are still running
  • 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 65119,
  "author": "jakebailey",
  "headCommitOid": "06400177359662265b3faf60f543307ef89595fd",
  "mergeBaseOid": "f2a72ab756d997bb762334b13ece43be4057f808",
  "lastPushDate": "2023-04-14T02:52:20.000Z",
  "lastActivityDate": "2023-04-14T02:52:44.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "ramda",
      "kind": "edit",
      "files": [
        {
          "path": "types/ramda/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "TheHandsomeCoder",
        "donnut",
        "mdekrey",
        "sbking",
        "afharo",
        "teves-castro",
        "hojberg",
        "samsonkeung",
        "angeloocana",
        "raynerd",
        "moshensky",
        "ethanresnick",
        "deftomat",
        "blimusiek",
        "biern",
        "rayhaneh",
        "rgm",
        "drewwyatt",
        "jottenlips",
        "minitesh",
        "krantisinh",
        "nemo108",
        "jituanlin",
        "Philippe-mills",
        "Saul-Mirone",
        "Nicholaiii",
        "LORDBABUINO",
        "couzic",
        "NEWESTERS",
        "adispring",
        "essenmitsosse",
        "harris-miller"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1507857153,
  "ciResult": "unknown"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests labels Apr 14, 2023
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Apr 14, 2023
@typescript-bot
Copy link
Contributor

@DangerBotOSS
Copy link

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

ramda (unpkg)

was missing the following properties:

  1. addIndexRight
  2. modifyPath
  3. sequence
  4. swap
  5. unwind

Generated by 🚫 dangerJS against 0640017

@jakebailey jakebailey merged commit 281fc27 into DefinitelyTyped:master Apr 14, 2023
2 checks passed
@jakebailey jakebailey deleted the ramda-0.29 branch April 14, 2023 02:59
@typescript-bot typescript-bot removed this from Waiting for Code Reviews in New Pull Request Status Board Apr 14, 2023
@jakebailey
Copy link
Member Author

Abusing my maintainer power to get this through. Forgive me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants